[GitHub] [incubator-streampark] xujiangfeng001 commented on a diff in pull request #2541: [ISSUE-2498][Feature] [SubTask] The cluster supports remote and yarn session heartbeat monitoring

["xujiangfeng001 (via GitHub)" <gi...@apache.org>]

xujiangfeng001 commented on code in PR #2541:
URL: https://github.com/apache/incubator-streampark/pull/2541#discussion_r1164311899


##########
streampark-common/src/main/java/org/apache/streampark/common/enums/ClusterState.java:
##########
@@ -24,12 +24,21 @@ public enum ClusterState implements Serializable {
   /** The cluster was just created but not started */
   CREATED(0),
   /** cluster started */
-  STARTED(1),
+  RUNNING(1),
   /** cluster stopped */
   STOPPED(2),
-
   /** cluster lost */
-  LOST(3);
+  LOST(3),
+  /** cluster undefined */
+  UNDEFINED(4),
+  /** cluster successfully */
+  SUCCEEDED(5),

Review Comment:
   When coding, I considered redefining an enumeration class to represent the obtained yarn final status, but later found that adding an enumeration class had redundancy in the status of the platform side. Therefore, I defined the status information of yarn final status in the platform side. Because I think this is non conflicting, and the platform side also needs these states to represent the running status of the flink cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org