[Impala-ASF-CR] IMPALA-8249: End-to-end test framework doesn't read aggregated counters properly

["Joe McDonnell (Code Review)" <ge...@cloudera.org>]

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12589 )

Change subject: IMPALA-8249: End-to-end test framework doesn't read aggregated counters properly
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

Thanks for fixing this.

I'm going to file a separate JIRA for us to think about implementing this using the Thrift profile. It might be a bit easier than parsing the text.

http://gerrit.cloudera.org:8080/#/c/12589/4/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:

http://gerrit.cloudera.org:8080/#/c/12589/4/tests/common/test_result_verifier.py@522
PS4, Line 522: It expects the profile to be written in
             :   verbose mode.
Nit: Small clarification.
"It expects the profile to write counters in verbose mode."



-- 
To view, visit http://gerrit.cloudera.org:8080/12589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a6fc0d3f7cbaa87aa848cdafffad21fb1514930
Gerrit-Change-Number: 12589
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 19:25:24 +0000
Gerrit-HasComments: Yes