[jira] Commented: (SHINDIG-811) Allow loading key for BlobCrypter security from resources or file

["Henning Schmiedehausen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662847#action_12662847 ] 

Henning Schmiedehausen commented on SHINDIG-811:
------------------------------------------------

Apart from the whitespace changes, that looks pretty good. Question: Why don't you load the file through a provider and give the actual value as a c'tor argument? 

> Allow loading key for BlobCrypter security from resources or file
> -----------------------------------------------------------------
>
>                 Key: SHINDIG-811
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-811
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Common Components (Java)
>            Reporter: Arnaud Bailly
>            Priority: Minor
>         Attachments: key-in-classpath.patch
>
>
> Loading a key from resources makes it simpler to 1) parameterize a shindig server for deployment (ie. filteringthe container.js with maven or ant) and 2) share the key with other servers/containers. There is already a ResourceLoader that can load files or resources if the naem is prefixed by 'res://', so just use it in BlobCrypterSecurityTokenDecoder.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.