You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/11/20 07:03:32 UTC

[GitHub] [incubator-doris] xy720 commented on a change in pull request #2252: Add pipes_as_concat_mode

xy720 commented on a change in pull request #2252: Add pipes_as_concat_mode
URL: https://github.com/apache/incubator-doris/pull/2252#discussion_r348318076
 
 

 ##########
 File path: fe/src/main/jflex/sql_scanner.flex
 ##########
 @@ -352,7 +352,7 @@ import org.apache.doris.common.util.SqlUtils;
         keywordMap.put("with", new Integer(SqlParserSymbols.KW_WITH));
         keywordMap.put("work", new Integer(SqlParserSymbols.KW_WORK));
         keywordMap.put("write", new Integer(SqlParserSymbols.KW_WRITE));
-        keywordMap.put("||", new Integer(SqlParserSymbols.KW_OR));
 
 Review comment:
   This is a change for KW_OR.
   There is two symbols map to KW_OR at the same time in origin:
   keywordMap.put("or", new Integer(SqlParserSymbols.KW_OR));
   keywordMap.put("||", new Integer(SqlParserSymbols.KW_OR));
   So this commit only change '||' and map it to a new id 'KW_PIPE'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org