[GitHub] [sling-org-apache-sling-event] mreutegg commented on pull request #24: SLING-11793 : limit log messages count for JobExecutionContext

["mreutegg (via GitHub)" <gi...@apache.org>]

mreutegg commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/24#issuecomment-1453553642

   I still think the current changes in this PR are not backward compatible. More specifically `Job.getProperty(String name)` and `Job.getProperty(String name, Class<T> type)` may now behave differently for property `PROPERTY_JOB_PROGRESS_LOG` and even violate the contract as written in JavaDoc for this field.
   > This property contains the optional output log of a job consumer. The value of this property is a string array.
   
   E.g. after a message is logged via `JobExecutionContext.log(String message, Object...args)`, `JobImpl` will return an `ArrayDeque` for property `PROPERTY_JOB_PROGRESS_LOG` or `null` if the property is read with a type of `String[]`.
   
   To me it seems like it would be better to keep `PROPERTY_JOB_PROGRESS_LOG` in `JobImpl.properties` as `String[]`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org