You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/08/14 08:39:30 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #745: Add streams

PragmaTwice commented on PR #745:
URL: https://github.com/apache/incubator-kvrocks/pull/745#issuecomment-1214312231

   > [redis_cmd.cc](https://github.com/apache/incubator-kvrocks/blob/unstable/src/redis_cmd.cc) file was already long because it contained the command implementation.
   > 
   > Now we have added a new `Stream` type, which is much longer. Maybe we'll add other new types in the future. They will definitely have a lot of commands too, which will make the file huge.
   > 
   > Should we consider splitting this file, separating the various types of commands into different files? HDYT @git-hulk @PragmaTwice
   
   It sounds reasonable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org