You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/19 04:54:11 UTC

[GitHub] [doris] xinyiZzz opened a new pull request, #13469: [enhancement](memtracker) Refactored thread context mem tracker macro

xinyiZzz opened a new pull request, #13469:
URL: https://github.com/apache/doris/pull/13469

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   1. Added `SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER`, switch MemTrackerLimiter for count memory during thread execution.
   2. Added `SCOPED_MEM_COUNT`, count a code segment memory (memory malloc - memory free) to int64_t.
   3. Improve the comments of thread context mem tracker related macros
   4. Fix thread mem tracker execeed limit duplicate log bug
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #13469: [enhancement](memtracker) Fix Brpc mem count and refactored thread context macro

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13469:
URL: https://github.com/apache/doris/pull/13469#issuecomment-1285259806

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 40.21 seconds
    load time: 596 seconds
    storage size: 17154823361 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221020175955_clickbench_pr_31997.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yiguolei commented on a diff in pull request #13469: [enhancement](memtracker) Fix Brpc mem count and refactored thread context macro

Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #13469:
URL: https://github.com/apache/doris/pull/13469#discussion_r1001339788


##########
be/src/runtime/memory/thread_mem_tracker_mgr.h:
##########
@@ -135,6 +146,10 @@ class ThreadMemTrackerMgr {
     // Frequent calls to unordered_map _untracked_mems[] in consume will degrade performance.
     int64_t _untracked_mem = 0;
     int64_t old_untracked_mem = 0;
+
+    bool _count_scope_mem = false;

Review Comment:
   This value is always false? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yiguolei merged pull request #13469: [enhancement](memtracker) Fix Brpc mem count and refactored thread context macro

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13469:
URL: https://github.com/apache/doris/pull/13469


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org