You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "showuon (via GitHub)" <gi...@apache.org> on 2023/09/05 10:19:21 UTC

[GitHub] [kafka] showuon commented on a diff in pull request #14335: MINOR: update comment in consumeAction

showuon commented on code in PR #14335:
URL: https://github.com/apache/kafka/pull/14335#discussion_r1315692410


##########
storage/src/test/java/org/apache/kafka/tiered/storage/actions/ConsumeAction.java:
##########
@@ -92,8 +92,7 @@ public void doExecute(TieredStorageTestContext context) throws InterruptedExcept
                 .findFirst();
 
         if (!firstExpectedRecordOpt.isPresent()) {
-            // If no records could be found in the second-tier storage or their offset are less
-            // than the consumer fetch offset, no record would be consumed from that storage.
+            // If no records could be found in the second-tier storage, no record would be consumed from that storage.

Review Comment:
   Obviously, we didn't check the `offset` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org