[GitHub] [cloudstack] nvazquez commented on a change in pull request #4138: Fixed incorrect error message on invalid template type download

[GitBox <gi...@apache.org>]

nvazquez commented on a change in pull request #4138:
URL: https://github.com/apache/cloudstack/pull/4138#discussion_r447636519



##########
File path: core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
##########
@@ -218,7 +219,10 @@ public long download(boolean resume, DownloadCompleteCallback callback) {
             errorString = hte.getMessage();

Review comment:
       Why not set it if errorString is null as below?

##########
File path: core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
##########
@@ -218,7 +219,10 @@ public long download(boolean resume, DownloadCompleteCallback callback) {
             errorString = hte.getMessage();
         } catch (IOException ioe) {
             status = TemplateDownloader.Status.UNRECOVERABLE_ERROR; //probably a file write error?
-            errorString = ioe.getMessage();
+            // Let's not overwrite the original error message.
+            if (errorString == null){

Review comment:
       Minor format one: can you leave a space between the closing parenthesis and the opening brace?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org