You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Bolke de Bruin <bd...@gmail.com> on 2019/09/12 17:44:32 UTC

Fwd: Outstanding review requests (patches!)

Ping!

I wonder what to do to grab some attention, because I see there is even
some duplication of effort going on now - ATLAS-3399 is partially
duplicated ATLAS-3378 which did receive reviews quickly? Do I need to add
reviewers? I do think the added functionality is worthwhile and will
benefit others too, but please let me know if those patches don’t make
sense.

Thanks for responding.

Bolke

On 4 September 2019 at 14:47:41, Bolke de Bruin (bdbruin@gmail.com) wrote:

Hello Team!

I have some outstanding review requests and I would appreciate feedback or
(duh) merging. Can someone take a look:

* Add order by (sort) to basic search : https://reviews.apache.org/r/71431/
* Use fulltext indices for dsl search :
https://reviews.apache.org/r/71344/ (Received
one “ship it!”, no further action)
* Expose total count of index searches : https://reviews.apache.org/r/71282/
* Set log level to warn for relationships without relationship definition :
https://reviews.apache.org/r/71278/. (This one is under review)

Thanks!
Bolke

Re: Outstanding review requests (patches!)

Posted by Kevin Wright <ke...@slalom.com>.
Hi,

I am having some issue unsubscribing from this list.  Can you help or suggest a path?  I couldn't reset a password on any links, it says I don't have an account.  Thanks ahead of time.  
 
Sincerely,
 
Kevin A. Wright
 
slalom
 
Fortune 100 Best Companies to Work For 2016-2018
Glassdoor Best Places to Work 2016-2019
Consulting Magazine Best Firms to Work For 2018
Human Rights Campaign Best Places to Work (100% Corporate Equality Index) 2015-2018
 
3630 Peachtree Road NE, Suite 500
Atlanta, GA 30326
404.849.2410 mobile
kevin.wright@slalom.com 
 
Visit us at Slalom.com <http://www.slalom.com/> • Facebook <http://www.facebook.com/slalomconsulting> • Twitter <http://twitter.com/#!/slalom> • LinkedIn <http://www.linkedin.com/company/slalom-consulting> • YouTube <http://www.youtube.com/user/SlalomConsulting> •  Thinking <https://www.slalom.com/thinking>
 

On 9/12/19, 1:44 PM, "Bolke de Bruin" <bd...@gmail.com> wrote:

    Ping!
    
    I wonder what to do to grab some attention, because I see there is even
    some duplication of effort going on now - ATLAS-3399 is partially
    duplicated ATLAS-3378 which did receive reviews quickly? Do I need to add
    reviewers? I do think the added functionality is worthwhile and will
    benefit others too, but please let me know if those patches don’t make
    sense.
    
    Thanks for responding.
    
    Bolke
    
    On 4 September 2019 at 14:47:41, Bolke de Bruin (bdbruin@gmail.com) wrote:
    
    Hello Team!
    
    I have some outstanding review requests and I would appreciate feedback or
    (duh) merging. Can someone take a look:
    
    * Add order by (sort) to basic search : https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.apache.org_r_71431_&d=DwIFaQ&c=fa_WZs7nNMvOIDyLmzi2sMVHyyC4hN9WQl29lWJQ5Y4&r=lTJnj8-KWTxaydoIAt4O_EnU4-aymDbcwnXP1Dx6PcY&m=-RI4YdME69Y6GySaOwZOlfxLFlhar-aFObPb3zAbMvk&s=LnVJT6HTJ5VOc4WDWc-BleL9VjPWH_71FAX4R1otMQc&e= 
    * Use fulltext indices for dsl search :
    https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.apache.org_r_71344_&d=DwIFaQ&c=fa_WZs7nNMvOIDyLmzi2sMVHyyC4hN9WQl29lWJQ5Y4&r=lTJnj8-KWTxaydoIAt4O_EnU4-aymDbcwnXP1Dx6PcY&m=-RI4YdME69Y6GySaOwZOlfxLFlhar-aFObPb3zAbMvk&s=ELZl5lN1E92KhK7UaAqe9sqd-cz1PFD9E7o-oGSlBL8&e=  (Received
    one “ship it!”, no further action)
    * Expose total count of index searches : https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.apache.org_r_71282_&d=DwIFaQ&c=fa_WZs7nNMvOIDyLmzi2sMVHyyC4hN9WQl29lWJQ5Y4&r=lTJnj8-KWTxaydoIAt4O_EnU4-aymDbcwnXP1Dx6PcY&m=-RI4YdME69Y6GySaOwZOlfxLFlhar-aFObPb3zAbMvk&s=rXibgGxiSSUT3STJE9gk2ERSxbgB9HoMPxMIHqB5Alo&e= 
    * Set log level to warn for relationships without relationship definition :
    https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.apache.org_r_71278_&d=DwIFaQ&c=fa_WZs7nNMvOIDyLmzi2sMVHyyC4hN9WQl29lWJQ5Y4&r=lTJnj8-KWTxaydoIAt4O_EnU4-aymDbcwnXP1Dx6PcY&m=-RI4YdME69Y6GySaOwZOlfxLFlhar-aFObPb3zAbMvk&s=g3eWcShQ28742Htihe28sPFqvc1CEFP2C3IahpfJU-c&e= . (This one is under review)
    
    Thanks!
    Bolke