You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/04/06 09:47:35 UTC
[GitHub] flink pull request #3684: [FLINK-6256] Fix outputTag variable name in Side O...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3684
[FLINK-6256] Fix outputTag variable name in Side Output docs
@kl0u Is this the issue of the JIRA or was there something else?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6256_output_docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3684.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3684
----
commit ced4e018cf396d233473867ce6239a60b8d9fc27
Author: zentol <ch...@apache.org>
Date: 2017-04-06T09:45:56Z
[FLINK-6256] Fix outputTag variable name in Side Output docs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3684: [FLINK-6256] Fix outputTag variable name in Side O...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3684#discussion_r110130934
--- Diff: docs/dev/stream/side_output.md ---
@@ -41,7 +41,7 @@ side output stream:
{% highlight java %}
// this needs to be an anonymous inner class, so that we can analyze the type
-OutputTag<String> outputTag = new OutputTag<String>("string-side-output") {};
+OutputTag<String> outputTag = new OutputTag<String>("side-output") {};
--- End diff --
done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3684: [FLINK-6256] Fix outputTag variable name in Side Output d...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3684
@kl0u done; i went with "side-output".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3684: [FLINK-6256] Fix outputTag variable name in Side O...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3684
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3684: [FLINK-6256] Fix outputTag variable name in Side Output d...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3684
@zentol Yes, this is the main issue, but you could also use the same name for the output tags between Java and Scala. Java uses "side-output" while Scala uses "string-side-output".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3684: [FLINK-6256] Fix outputTag variable name in Side Output d...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3684
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3684: [FLINK-6256] Fix outputTag variable name in Side O...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3684#discussion_r110125718
--- Diff: docs/dev/stream/side_output.md ---
@@ -41,7 +41,7 @@ side output stream:
{% highlight java %}
// this needs to be an anonymous inner class, so that we can analyze the type
-OutputTag<String> outputTag = new OutputTag<String>("string-side-output") {};
+OutputTag<String> outputTag = new OutputTag<String>("side-output") {};
--- End diff --
You should update the Scala.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3684: [FLINK-6256] Fix outputTag variable name in Side Output d...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3684
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---