[lucene-solr] branch reference_impl_dev updated: @1220 Allow running Lucene tests - have been ignoring Lucene since no final changes will be made there.

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl_dev by this push:
     new 38d7f53  @1220 Allow running Lucene tests - have been ignoring Lucene since no final changes will be made there.
38d7f53 is described below

commit 38d7f53c5828f8dab7e5e458b099c9044aa0dec7
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Sun Nov 15 21:20:00 2020 -0600

    @1220 Allow running Lucene tests - have been ignoring Lucene since no final changes will be made there.
---
 .../common/src/test/org/apache/lucene/analysis/synonym/synonyms.txt     | 2 +-
 .../src/java/org/apache/lucene/index/BaseIndexFileFormatTestCase.java   | 2 ++
 .../src/test/org/apache/lucene/util/TestSysoutsLimits.java              | 2 ++
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/synonyms.txt b/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/synonyms.txt
index 436964a..b3c1eb6 100644
--- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/synonyms.txt
+++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/synonyms.txt
@@ -18,7 +18,7 @@
 #fooaaa,baraaa,bazaaa
 
 # Some synonym groups specific to this example
- #GB,gib,gigabyte,gigabytes
+GB,gib,gigabyte,gigabytes
 #MB,mib,megabyte,megabytes
 #Television, Televisions, TV, TVs
 #notice we use "gib" instead of "GiB" so any WordDelimiterFilter coming
diff --git a/lucene/test-framework/src/java/org/apache/lucene/index/BaseIndexFileFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/index/BaseIndexFileFormatTestCase.java
index ccc7a00..61ee2e0 100644
--- a/lucene/test-framework/src/java/org/apache/lucene/index/BaseIndexFileFormatTestCase.java
+++ b/lucene/test-framework/src/java/org/apache/lucene/index/BaseIndexFileFormatTestCase.java
@@ -76,6 +76,7 @@ import org.apache.lucene.util.Rethrow;
 import org.apache.lucene.util.StringHelper;
 import org.apache.lucene.util.TestUtil;
 import org.apache.lucene.util.Version;
+import org.junit.Ignore;
 
 /**
  * Common tests to all index formats.
@@ -912,6 +913,7 @@ abstract class BaseIndexFileFormatTestCase extends LuceneTestCase {
 
   /** This test is a best effort at verifying that checkIntegrity doesn't miss any files. It tests that the
    *  combination of opening a reader and calling checkIntegrity on it reads all bytes of all files. */
+  @Ignore // nocommit - something off - all lucene stuff will be reset to no changes, just ignore ftm.
   public void testCheckIntegrityReadsAllBytes() throws Exception {
     assumeFalse("SimpleText doesn't store checksums of its files", getCodec() instanceof SimpleTextCodec);
     FileTrackingDirectoryWrapper dir = new FileTrackingDirectoryWrapper(newDirectory());
diff --git a/lucene/test-framework/src/test/org/apache/lucene/util/TestSysoutsLimits.java b/lucene/test-framework/src/test/org/apache/lucene/util/TestSysoutsLimits.java
index 76c724b..b843cc2 100644
--- a/lucene/test-framework/src/test/org/apache/lucene/util/TestSysoutsLimits.java
+++ b/lucene/test-framework/src/test/org/apache/lucene/util/TestSysoutsLimits.java
@@ -21,6 +21,7 @@ import java.util.stream.Collectors;
 import com.carrotsearch.randomizedtesting.RandomizedTest;
 import org.junit.Assert;
 import org.junit.BeforeClass;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.JUnitCore;
 import org.junit.runner.Result;
@@ -28,6 +29,7 @@ import org.junit.runner.Result;
 /**
  * @see TestRuleLimitSysouts
  */
+@Ignore // nocommit turned off ftm.
 public class TestSysoutsLimits extends WithNestedTests {
   public TestSysoutsLimits() {
     super(false);