[GitHub] [incubator-doris] morningman commented on a change in pull request #4717: Support full StreamLoad feature in multiload

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #4717:
URL: https://github.com/apache/incubator-doris/pull/4717#discussion_r530280143



##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/FeMetaVersion.java
##########
@@ -199,5 +199,5 @@
     //jira: 4863 for load job support udf
     public static final int VERSION_93 = 93;
     // note: when increment meta version, should assign the latest version to VERSION_CURRENT
-    public static final int VERSION_CURRENT = VERSION_93;
+    public static final int VERSION_CURRENT = VERSION_92;

Review comment:
       ? Wrong version?

##########
File path: be/src/http/action/mini_load.cpp
##########
@@ -165,10 +166,12 @@ Status MiniLoadAction::_load(
         HttpRequest* http_req,
         const std::string& file_path,
         const std::string& user,
-        const std::string& cluster) {
+        const std::string& cluster,
+        int64_t file_size) {
     // Prepare request parameters.
     std::map<std::string, std::string> params(
             http_req->query_params().begin(), http_req->query_params().end());
+    RETURN_IF_ERROR(_merge_header(http_req, &params));

Review comment:
       Add a comment to say that the param in header will overwrite the query params




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org