You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by je...@jakarta.apache.org on 2004/09/05 20:57:36 UTC

[jira] Created: (JS2-115) Simplify vavle structure

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JS2-115

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JS2-115
    Summary: Simplify vavle structure
       Type: Improvement

     Status: Unassigned
   Priority: Major

    Project: Jetspeed 2
 Components: 
             Container
   Versions:
             2.0-a1

   Assignee: 
   Reporter: David Jencks

    Created: Sun, 5 Sep 2004 11:56 AM
    Updated: Sun, 5 Sep 2004 11:56 AM
Environment: all

Description:
The current valve structure is excessively complicated for no reason.  This patch replaces the design with a simple linked list of valves and makes all plausible variables final.  Pipeline is also removed as it is no longer necessary.

The spring configuration file has both the previous pipeline definitions commented out and the new configuration to make it easier to verify that the implementations are equivalent.

I personally think that building the pipelines in a java class (that is specified in the spring configuration) would be considerably clearer than this xml configuration.  Very few people will want to change the piplines, and anyone who does should certainly be able to modify/extend/implement a java setup class.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org

[jira] Updated: (JS2-115) Simplify vavle structure

Posted by je...@jakarta.apache.org.
The following issue has been updated:

    Updater: David Jencks (mailto:djencks@apache.org)
       Date: Sun, 5 Sep 2004 11:58 AM
    Comment:
modified files in j2
    Changes:
             Attachment changed to valve.diff
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://issues.apache.org/jira/browse/JS2-115?page=history

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JS2-115

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JS2-115
    Summary: Simplify vavle structure
       Type: Improvement

     Status: Unassigned
   Priority: Major

    Project: Jetspeed 2
 Components: 
             Container
   Versions:
             2.0-a1

   Assignee: 
   Reporter: David Jencks

    Created: Sun, 5 Sep 2004 11:56 AM
    Updated: Sun, 5 Sep 2004 11:58 AM
Environment: all

Description:
The current valve structure is excessively complicated for no reason.  This patch replaces the design with a simple linked list of valves and makes all plausible variables final.  Pipeline is also removed as it is no longer necessary.

The spring configuration file has both the previous pipeline definitions commented out and the new configuration to make it easier to verify that the implementations are equivalent.

I personally think that building the pipelines in a java class (that is specified in the spring configuration) would be considerably clearer than this xml configuration.  Very few people will want to change the piplines, and anyone who does should certainly be able to modify/extend/implement a java setup class.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org

[jira] Updated: (JS2-115) Simplify vavle structure

Posted by je...@jakarta.apache.org.
The following issue has been updated:

    Updater: David Jencks (mailto:djencks@apache.org)
       Date: Sun, 5 Sep 2004 11:58 AM
    Comment:
list of files deleted from j2
    Changes:
             Attachment changed to deleted-files
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://issues.apache.org/jira/browse/JS2-115?page=history

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JS2-115

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JS2-115
    Summary: Simplify vavle structure
       Type: Improvement

     Status: Unassigned
   Priority: Major

    Project: Jetspeed 2
 Components: 
             Container
   Versions:
             2.0-a1

   Assignee: 
   Reporter: David Jencks

    Created: Sun, 5 Sep 2004 11:56 AM
    Updated: Sun, 5 Sep 2004 11:58 AM
Environment: all

Description:
The current valve structure is excessively complicated for no reason.  This patch replaces the design with a simple linked list of valves and makes all plausible variables final.  Pipeline is also removed as it is no longer necessary.

The spring configuration file has both the previous pipeline definitions commented out and the new configuration to make it easier to verify that the implementations are equivalent.

I personally think that building the pipelines in a java class (that is specified in the spring configuration) would be considerably clearer than this xml configuration.  Very few people will want to change the piplines, and anyone who does should certainly be able to modify/extend/implement a java setup class.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org

[jira] Updated: (JS2-115) Simplify vavle structure

Posted by je...@jakarta.apache.org.
The following issue has been updated:

    Updater: David Jencks (mailto:djencks@apache.org)
       Date: Sun, 5 Sep 2004 1:00 PM
    Comment:
Changes for fusion.  I'm having some trouble testing this, something else in my j1 appears to be broken.
    Changes:
             Attachment changed to j1-valves.diff
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://issues.apache.org/jira/browse/JS2-115?page=history

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JS2-115

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JS2-115
    Summary: Simplify vavle structure
       Type: Improvement

     Status: Unassigned
   Priority: Major

    Project: Jetspeed 2
 Components: 
             Container
   Versions:
             2.0-a1

   Assignee: 
   Reporter: David Jencks

    Created: Sun, 5 Sep 2004 11:56 AM
    Updated: Sun, 5 Sep 2004 1:00 PM
Environment: all

Description:
The current valve structure is excessively complicated for no reason.  This patch replaces the design with a simple linked list of valves and makes all plausible variables final.  Pipeline is also removed as it is no longer necessary.

The spring configuration file has both the previous pipeline definitions commented out and the new configuration to make it easier to verify that the implementations are equivalent.

I personally think that building the pipelines in a java class (that is specified in the spring configuration) would be considerably clearer than this xml configuration.  Very few people will want to change the piplines, and anyone who does should certainly be able to modify/extend/implement a java setup class.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org

[jira] Updated: (JS2-115) Simplify vavle structure

Posted by je...@jakarta.apache.org.
The following issue has been updated:

    Updater: David Jencks (mailto:djencks@apache.org)
       Date: Sun, 5 Sep 2004 12:21 PM
    Comment:
Added no-op valve
    Changes:
             Attachment changed to newvalve.jar
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://issues.apache.org/jira/browse/JS2-115?page=history

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JS2-115

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JS2-115
    Summary: Simplify vavle structure
       Type: Improvement

     Status: Unassigned
   Priority: Major

    Project: Jetspeed 2
 Components: 
             Container
   Versions:
             2.0-a1

   Assignee: 
   Reporter: David Jencks

    Created: Sun, 5 Sep 2004 11:56 AM
    Updated: Sun, 5 Sep 2004 12:21 PM
Environment: all

Description:
The current valve structure is excessively complicated for no reason.  This patch replaces the design with a simple linked list of valves and makes all plausible variables final.  Pipeline is also removed as it is no longer necessary.

The spring configuration file has both the previous pipeline definitions commented out and the new configuration to make it easier to verify that the implementations are equivalent.

I personally think that building the pipelines in a java class (that is specified in the spring configuration) would be considerably clearer than this xml configuration.  Very few people will want to change the piplines, and anyone who does should certainly be able to modify/extend/implement a java setup class.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org

[jira] Closed: (JS2-115) Simplify vavle structure

Posted by "Ate Douma (JIRA)" <je...@portals.apache.org>.
     [ http://issues.apache.org/jira/browse/JS2-115?page=all ]
     
Ate Douma closed JS2-115:
-------------------------

    Resolution: Won't Fix

No longer of interest as we have moved on since.

> Simplify vavle structure
> ------------------------
>
>          Key: JS2-115
>          URL: http://issues.apache.org/jira/browse/JS2-115
>      Project: Jetspeed 2
>         Type: Improvement
>   Components: Container
>     Versions: 2.0-a1
>  Environment: all
>     Reporter: David Jencks
>  Attachments: deleted-files, j1-valves.diff, newvalve.jar, valve.diff
>
> The current valve structure is excessively complicated for no reason.  This patch replaces the design with a simple linked list of valves and makes all plausible variables final.  Pipeline is also removed as it is no longer necessary.
> The spring configuration file has both the previous pipeline definitions commented out and the new configuration to make it easier to verify that the implementations are equivalent.
> I personally think that building the pipelines in a java class (that is specified in the spring configuration) would be considerably clearer than this xml configuration.  Very few people will want to change the piplines, and anyone who does should certainly be able to modify/extend/implement a java setup class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org