You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "poorbarcode (via GitHub)" <gi...@apache.org> on 2025/08/28 16:39:38 UTC
[PR] [improve][test]Add new test PartitionCreationTest.testGetPoliciesIfPartitionsNotCreated [pulsar]
poorbarcode opened a new pull request, #24681:
URL: https://github.com/apache/pulsar/pull/24681
### Motivation
`branch-4.0` has such an issue, which occurs as follows. I have pushed a PR to fix it #24680
- Create a partitioned topic with 2 partitions
- All partitions are deleted because the feature `brokerDeleteInactiveTopicsEnabled` is `true`
- Try to get the topic-level policies; you will get a Topic not found error
The master branch does not have the issue because #24225 have fixed it [here](https://github.com/apache/pulsar/pull/24225/files#diff-6902810fd24ff29ec34052bcc6a0de36d76107649148d945b80ec2be888e9042L734-R778)
This PR is in order to add the same test as #24680
### Modifications
Add a new test `PartitionCreationTest.testGetPoliciesIfPartitionsNotCreated`
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][test]Add new test PartitionCreationTest.testGetPoliciesIfPartitionsNotCreated [pulsar]
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #24681:
URL: https://github.com/apache/pulsar/pull/24681#issuecomment-3234210965
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][test]Add new test PartitionCreationTest.testGetPoliciesIfPartitionsNotCreated [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24681:
URL: https://github.com/apache/pulsar/pull/24681#issuecomment-3235004458
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24681?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.20%. Comparing base ([`490ba0c`](https://app.codecov.io/gh/apache/pulsar/commit/490ba0cca18f713091e6fce3d3d6390386c1f3cf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e8d439`](https://app.codecov.io/gh/apache/pulsar/commit/4e8d439ff0d46e577633d3711d4f5bab9273d4b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/24681?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #24681 +/- ##
=============================================
+ Coverage 38.72% 74.20% +35.47%
- Complexity 13076 33383 +20307
=============================================
Files 1836 1893 +57
Lines 143697 147772 +4075
Branches 16616 17089 +473
=============================================
+ Hits 55650 109655 +54005
+ Misses 80600 29360 -51240
- Partials 7447 8757 +1310
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/24681/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/24681/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.56% <ø> (-0.08%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/24681/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `22.73% <ø> (+0.01%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/24681/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.69% <ø> (+39.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1391 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/24681/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][test]Add new test PartitionCreationTest.testGetPoliciesIfPartitionsNotCreated [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #24681:
URL: https://github.com/apache/pulsar/pull/24681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org