You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/04/19 09:51:15 UTC

Review Request 46375: Updated MACHINE_UP_HELP's comments.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46375/
-----------------------------------------------------------

Review request for mesos, Joris Van Remoortere and Joseph Wu.


Repository: mesos


Description
-------

Updated MACHINE_UP_HELP's comments.


Diffs
-----

  src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 

Diff: https://reviews.apache.org/r/46375/diff/


Testing
-------

make


Thanks,

Klaus Ma


Re: Review Request 46375: Updated MACHINE_UP_HELP's comments.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46375/#review129614
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On April 19, 2016, 12:51 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46375/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 12:51 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated MACHINE_UP_HELP's comments.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 
> 
> Diff: https://reviews.apache.org/r/46375/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Re: Review Request 46375: Updated MACHINE_UP_HELP's comments.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46375/#review129513
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46375]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 19, 2016, 7:51 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46375/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 7:51 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated MACHINE_UP_HELP's comments.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 
> 
> Diff: https://reviews.apache.org/r/46375/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>