You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/07/19 16:35:24 UTC
[GitHub] [incubator-pekko-http] pjfanning opened a new pull request, #256: add CORS specific notice to pekko-http-cors jar
pjfanning opened a new pull request, #256:
URL: https://github.com/apache/incubator-pekko-http/pull/256
* build currently adds the short PekkoNotice to the pekko-http-cors and it would be better to include the acknowledgement of Lomi Mégard's code donation
* the big NOTICE in project root can still serve as the pekko-http-core jar because almost the entries relate to that jar - not that much point having a slightly truncated copy to put in pekko-http-core jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning merged pull request #256: add CORS specific notice to pekko-http-cors jar
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #256:
URL: https://github.com/apache/incubator-pekko-http/pull/256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin commented on a diff in pull request #256: add CORS specific notice to pekko-http-cors jar
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #256:
URL: https://github.com/apache/incubator-pekko-http/pull/256#discussion_r1269074869
##########
project/AddMetaInfLicenseFiles.scala:
##########
@@ -41,6 +41,13 @@ object AddMetaInfLicenseFiles extends AutoPlugin {
apacheSonatypeLicenseFile := baseDir.value / "LICENSE",
apacheSonatypeNoticeFile := baseDir.value / "NOTICE")
+ /**
+ * Settings specific for Pekko http-cors subproject which require a different license file.
+ */
+ lazy val httpCorsSettings = Seq(
+ apacheSonatypeLicenseFile := baseDir.value / "legal" / "StandardLicense.txt",
+ apacheSonatypeNoticeFile := baseDir.value / "legal" / "CorsNotice.txt")
Review Comment:
does it need a `DISCLAIMER` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #256: add CORS specific notice to pekko-http-cors jar
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #256:
URL: https://github.com/apache/incubator-pekko-http/pull/256#discussion_r1269087023
##########
project/AddMetaInfLicenseFiles.scala:
##########
@@ -41,6 +41,13 @@ object AddMetaInfLicenseFiles extends AutoPlugin {
apacheSonatypeLicenseFile := baseDir.value / "LICENSE",
apacheSonatypeNoticeFile := baseDir.value / "NOTICE")
+ /**
+ * Settings specific for Pekko http-cors subproject which require a different license file.
+ */
+ lazy val httpCorsSettings = Seq(
+ apacheSonatypeLicenseFile := baseDir.value / "legal" / "StandardLicense.txt",
+ apacheSonatypeNoticeFile := baseDir.value / "legal" / "CorsNotice.txt")
Review Comment:
Yes, by default https://github.com/mdedetrich/sbt-apache-sonatype will add the DISCLAIMER into `projectSettings` since its a mandatory for ASF projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #256: add CORS specific notice to pekko-http-cors jar
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #256:
URL: https://github.com/apache/incubator-pekko-http/pull/256#discussion_r1269081318
##########
project/AddMetaInfLicenseFiles.scala:
##########
@@ -41,6 +41,13 @@ object AddMetaInfLicenseFiles extends AutoPlugin {
apacheSonatypeLicenseFile := baseDir.value / "LICENSE",
apacheSonatypeNoticeFile := baseDir.value / "NOTICE")
+ /**
+ * Settings specific for Pekko http-cors subproject which require a different license file.
+ */
+ lazy val httpCorsSettings = Seq(
+ apacheSonatypeLicenseFile := baseDir.value / "legal" / "StandardLicense.txt",
+ apacheSonatypeNoticeFile := baseDir.value / "legal" / "CorsNotice.txt")
Review Comment:
this is inherited from the projectSetting - that adds the DISCLAIMER to all jars - it is the same DISCLAIMER in all jars but the LICENSE and NOTICE can be specific to a jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org