You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/22 02:49:47 UTC

[GitHub] [airflow] russellpierce commented on a change in pull request #5488: [AIRFLOW-4880] Add success, failure and fail_on_empty params to SqlSensor

russellpierce commented on a change in pull request #5488: [AIRFLOW-4880] Add success, failure and fail_on_empty params to SqlSensor
URL: https://github.com/apache/airflow/pull/5488#discussion_r305658348
 
 

 ##########
 File path: airflow/sensors/sql_sensor.py
 ##########
 @@ -27,8 +27,13 @@
 
 class SqlSensor(BaseSensorOperator):
     """
-    Runs a sql statement until a criteria is met. It will keep trying while
-    sql returns no row, or if the first cell in (0, '0', '').
+    Runs a sql statement repeteadly until a criteria is met. It will keep trying until
 
 Review comment:
   ```suggestion
       Runs a sql statement repeatedly until a criteria is met. It will keep trying until
   ```
   Corrected typo.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services