You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/03/23 16:24:31 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #8727: Format change logs in a better way.

wu-sheng commented on a change in pull request #8727:
URL: https://github.com/apache/skywalking/pull/8727#discussion_r833409727



##########
File path: CHANGES.md
##########
@@ -99,8 +99,8 @@ Release Notes.
 * Expose more ElasticSearch health check related logs to help to
   diagnose `Health check fails. reason: No healthy endpoint`.
 * Add source `event` generated metrics to SERVICE_CATALOG_NAME catalog.
-* [Breaking Change] Deprecate `All` from OAL source.
-* [Breaking Change] Remove `SRC_ALL: 'All'` from OAL grammar tree.
+* [**Break Change**] Deprecate `All` from OAL source.

Review comment:
       I was trying to change in another way

##########
File path: CHANGES.md
##########
@@ -99,8 +99,8 @@ Release Notes.
 * Expose more ElasticSearch health check related logs to help to
   diagnose `Health check fails. reason: No healthy endpoint`.
 * Add source `event` generated metrics to SERVICE_CATALOG_NAME catalog.
-* [Breaking Change] Deprecate `All` from OAL source.
-* [Breaking Change] Remove `SRC_ALL: 'All'` from OAL grammar tree.
+* [**Break Change**] Deprecate `All` from OAL source.

Review comment:
       I think this is unexpected :(




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org