You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/10/09 10:18:01 UTC
[GitHub] [pulsar-helm-chart] hangc0276 opened a new pull request #165: useV2WireProtocol for bookkeeper autorecovery
hangc0276 opened a new pull request #165:
URL: https://github.com/apache/pulsar-helm-chart/pull/165
### Motivation
Currently we only set `bookkeeperUseV2WireProtocol=true` on Pulsar brokers to enforce brokers to use v2 protocol to avoid GC issues introduced by protobuf.
However, we don’t set this setting on autorecovery, and the default value is `false`, Hence AutoRecovery will use v3 protocol.
We'd better set `useV2WireProtocol=true` in autorecovery in the helm charts
### Modifications
Set `useV2WireProtocol=true` in autorecovery.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] frankjkelly commented on pull request #165: useV2WireProtocol for bookkeeper autorecovery
Posted by GitBox <gi...@apache.org>.
frankjkelly commented on pull request #165:
URL: https://github.com/apache/pulsar-helm-chart/pull/165#issuecomment-940988386
Just for my information can someone explain why Autorecovery should use the V2 protocol but the Broker V3? Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] hangc0276 commented on pull request #165: useV2WireProtocol for bookkeeper autorecovery
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #165:
URL: https://github.com/apache/pulsar-helm-chart/pull/165#issuecomment-941868430
> Just for my information can someone explain why Autorecovery should use the V2 protocol but the Broker V3? Thanks in advance!
@frankjkelly I broker side, it has been set the bookie client use V2 protocol by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] hangc0276 commented on pull request #165: useV2WireProtocol for bookkeeper autorecovery
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #165:
URL: https://github.com/apache/pulsar-helm-chart/pull/165#issuecomment-941868430
> Just for my information can someone explain why Autorecovery should use the V2 protocol but the Broker V3? Thanks in advance!
@frankjkelly I broker side, it has been set the bookie client use V2 protocol by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari merged pull request #165: useV2WireProtocol for bookkeeper autorecovery
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #165:
URL: https://github.com/apache/pulsar-helm-chart/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] frankjkelly commented on pull request #165: useV2WireProtocol for bookkeeper autorecovery
Posted by GitBox <gi...@apache.org>.
frankjkelly commented on pull request #165:
URL: https://github.com/apache/pulsar-helm-chart/pull/165#issuecomment-941069144
Thanks @eolivelli !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] eolivelli commented on pull request #165: useV2WireProtocol for bookkeeper autorecovery
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #165:
URL: https://github.com/apache/pulsar-helm-chart/pull/165#issuecomment-941064004
if you want to leverage ExplicitLAC feature you need V3, so it is better to use V3 on the broker.
AutoRecovery needs only to read/write to the bookies, no need for ExplicitLAC API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org