You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Nick *** <do...@abv.bg> on 2005/06/09 16:14:30 UTC
Fix a couple of warnings on win32
- fix a malicious regexp (it was failing for 'c:/path/to')
- fix the "No library found" warnings when building without apxs and MP_AP_PREFIX
Index: lib/Apache2/Build.pm
===================================================================
--- lib/Apache2/Build.pm (revision 189748)
+++ lib/Apache2/Build.pm (working copy)
@@ -932,7 +932,7 @@
for (qw(ap_includedir)) {
delete $self->{$_};
}
- if ($dir =~ m:^../:) {
+ if ($dir =~ m:^\.\.[/\\]:) {
$dir = "$self->{cwd}/$dir";
}
$self->{dir} = $dir;
@@ -1546,7 +1546,7 @@
sub apache_libs_MSWin32 {
my $self = shift;
- my $prefix = $self->apxs(-q => 'PREFIX');
+ my $prefix = $self->apxs(-q => 'PREFIX') || $self->dir;
my @libs = map { "$prefix/lib/lib$_.lib" } qw(apr aprutil httpd);
"@libs";
}
BTW, I get an error on win32 with ActivePerl 5.8.7, AP 2.0.54 and the latest MP2 svn
cl -IE:/cygwin/usr/src/mod_perl-2.0/src/modules/perl -IE:/cygwin/usr/src
/mod_perl-2.0/xs -Ie:/sites/servers/apache2/apache2/include -nologo -Gf -W3 -MD
-Zi -DNDEBUG -O1 -DWIN32 -D_CONSOLE -DNO_STRICT -DHAVE_DES_FCRYPT -DBUILT_BY_ACT
IVESTATE -DNO_HASH_SEED -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLI
CIT_SYS -DUSE_PERLIO -DPERL_MSVCRT_READFIX -I"E:\Sites\Perl\lib\CORE" -DMOD_PERL
-DMP_COMPAT_1X -MD -Zi -DNDEBUG -O1 -c modperl_module.c && E:\Sites\Perl\bin\
perl.exe -MExtUtils::Command -e mv modperl_module.obj modperl_module.lo
modperl_module.c
modperl_module.c(170) : error C2143: syntax error : missing ';' before 'type'
modperl_module.c(185) : error C2065: 'interp' : undeclared identifier
modperl_module.c(185) : warning C4047: '=' : 'int' differs in levels of indirect
ion from 'modperl_interp_t *'
modperl_module.c(186) : error C2223: left of '->perl' must point to struct/union
NMAKE : fatal error U1077: 'cl' : return code '0x2'
I don't have a patch for this one.
-----------------------------------------------------------------
http://izbori2005.netinfo.bg - Избори 2005 - Само най-важното. Виж, чуй, прочети и избери!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fix a couple of warnings on win32
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Fri, 10 Jun 2005, Philippe M. Chiasson wrote:
> Nick *** wrote:
[ ... ]
> > BTW, I get an error on win32 with ActivePerl 5.8.7, AP
> > 2.0.54 and the latest MP2 svn
> >
> > cl -IE:/cygwin/usr/src/mod_perl-2.0/src/modules/perl -IE:/cygwin/usr/src
> > /mod_perl-2.0/xs -Ie:/sites/servers/apache2/apache2/include -nologo -Gf -W3 -MD
> > -Zi -DNDEBUG -O1 -DWIN32 -D_CONSOLE -DNO_STRICT -DHAVE_DES_FCRYPT -DBUILT_BY_ACT
> > IVESTATE -DNO_HASH_SEED -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLI
> > CIT_SYS -DUSE_PERLIO -DPERL_MSVCRT_READFIX -I"E:\Sites\Perl\lib\CORE" -DMOD_PERL
> > -DMP_COMPAT_1X -MD -Zi -DNDEBUG -O1 -c modperl_module.c && E:\Sites\Perl\bin\
> > perl.exe -MExtUtils::Command -e mv modperl_module.obj modperl_module.lo
> > modperl_module.c
> > modperl_module.c(170) : error C2143: syntax error : missing ';' before 'type'
> > modperl_module.c(185) : error C2065: 'interp' : undeclared identifier
> > modperl_module.c(185) : warning C4047: '=' : 'int' differs in levels of indirect
> > ion from 'modperl_interp_t *'
> > modperl_module.c(186) : error C2223: left of '->perl' must point to struct/union
> >
> > NMAKE : fatal error U1077: 'cl' : return code '0x2'
> >
> > I don't have a patch for this one.
>
> Looks like there is something wrong with
> MP_PERL_CONTEXT_DECLARE's definition. I just tried with
> ActivePerl 5.8.7 on Linux successfully.
Nick, could you try the current svn sources - I think
this should be fixed now.
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fix a couple of warnings on win32
Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Nick *** wrote:
> - fix a malicious regexp (it was failing for 'c:/path/to')
> - fix the "No library found" warnings when building without apxs and MP_AP_PREFIX
[...]
thanks Nick, comitted as r189910 & 189913
> BTW, I get an error on win32 with ActivePerl 5.8.7, AP 2.0.54 and the latest MP2 svn
>
> cl -IE:/cygwin/usr/src/mod_perl-2.0/src/modules/perl -IE:/cygwin/usr/src
> /mod_perl-2.0/xs -Ie:/sites/servers/apache2/apache2/include -nologo -Gf -W3 -MD
> -Zi -DNDEBUG -O1 -DWIN32 -D_CONSOLE -DNO_STRICT -DHAVE_DES_FCRYPT -DBUILT_BY_ACT
> IVESTATE -DNO_HASH_SEED -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLI
> CIT_SYS -DUSE_PERLIO -DPERL_MSVCRT_READFIX -I"E:\Sites\Perl\lib\CORE" -DMOD_PERL
> -DMP_COMPAT_1X -MD -Zi -DNDEBUG -O1 -c modperl_module.c && E:\Sites\Perl\bin\
> perl.exe -MExtUtils::Command -e mv modperl_module.obj modperl_module.lo
> modperl_module.c
> modperl_module.c(170) : error C2143: syntax error : missing ';' before 'type'
> modperl_module.c(185) : error C2065: 'interp' : undeclared identifier
> modperl_module.c(185) : warning C4047: '=' : 'int' differs in levels of indirect
> ion from 'modperl_interp_t *'
> modperl_module.c(186) : error C2223: left of '->perl' must point to struct/union
>
> NMAKE : fatal error U1077: 'cl' : return code '0x2'
>
> I don't have a patch for this one.
Looks like there is something wrong with MP_PERL_CONTEXT_DECLARE's definition.
I just tried with ActivePerl 5.8.7 on Linux successfully.
--
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5