[GitHub] [tvm] areusch commented on a change in pull request #7742: Contributing the STM32 port

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #7742:
URL: https://github.com/apache/tvm/pull/7742#discussion_r616780971



##########
File path: apps/stm32/.clang-format
##########
@@ -0,0 +1,2 @@
+DisableFormat: true

Review comment:
       just curious why you needed to do this?

##########
File path: apps/stm32/Makefile
##########
@@ -0,0 +1,90 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Top level Makefile for the STM32 microcontroller project.
+
+#
+# Set the path to your ARM Toolset.
+# Only gcc is supported at this time.
+#
+#export ARM_PATH ?= 
+ifndef ARM_PATH
+$(error ARM_PATH must be set and point at your GCC ARM compiler installation)
+endif
+
+#
+# Set the path to your TVM compiler installation
+#
+#export TVM_PATH ?= 
+ifndef TVM_PATH
+$(error TVM_PATH must be set and point at your TVM stack installation)
+endif
+
+#
+# Set the path to your CubeMX installation
+#
+#export X_CUBE_PATH ?= 
+ifndef X_CUBE_PATH
+$(error X_CUBE_PATH must be set and point at your STM32 Cube Firmware installation)
+endif
+
+#export X_CUBE_TOOL_PATH ?= 
+ifndef X_CUBE_TOOL_PATH
+$(error X_CUBE_TOOL_PATH must be set and point at your STM32 Cube Programmer installation)
+endif
+
+#
+# Setup path to your network generated files
+#
+#export MODEL_PATH = 
+ifndef MODEL_PATH
+$(error MODEL_PATH must be set and point at your model implementation generated with the TVM compiler)
+endif
+
+BOARD ?= h747idisco

Review comment:
       could you comment what's special about this board that makes it the default?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org