You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/12 13:26:00 UTC

[jira] [Commented] (ARTEMIS-1981) JDBCJournalImpl constructor isn't using tableName parameter

    [ https://issues.apache.org/jira/browse/ARTEMIS-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541635#comment-16541635 ] 

ASF GitHub Bot commented on ARTEMIS-1981:
-----------------------------------------

GitHub user franz1981 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2182

    ARTEMIS-1981 JDBCJournalImpl constructor isn't using tableName parameter

    Removed the unused/redundant constructor parameter tableName

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-1981

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2182
    
----
commit 9df9a1a4586a5f960a818cfa94299bc45fe8ba04
Author: Francesco Nigro <ni...@...>
Date:   2018-07-12T13:24:32Z

    ARTEMIS-1981 JDBCJournalImpl constructor isn't using tableName parameter
    
    Removed the unused/redundant constructor parameter tableName

----


> JDBCJournalImpl constructor isn't using tableName parameter
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-1981
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1981
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.6.2
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Trivial
>              Labels: jdbc
>             Fix For: 2.7.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> JDBCJournalImpl is exposing in the constructor an unused and redundant tableName parameter: would be better to drop it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)