You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/01/20 02:41:07 UTC
[PR] GH-537: [Release][Docs] Generate API reference [arrow-java]
kou opened a new pull request, #538:
URL: https://github.com/apache/arrow-java/pull/538
The followings are out-of-scope:
* Generate Sphinx based documents
* Publish this to https://arrow.apache.org/java/reference/ in release process
* Publish this to https://arrow.apache.org/dev/reference/ nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-537: [Release][Docs] Generate API reference [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #538:
URL: https://github.com/apache/arrow-java/pull/538#discussion_r1921737882
##########
ci/scripts/build.sh:
##########
@@ -61,27 +59,38 @@ done
pushd "${build_dir}"
-if [ "${ARROW_JAVA_SHADE_FLATBUFFERS}" == "ON" ]; then
+# TODO: ARROW_JAVA_SHADE_FLATBUFFERS isn't used for our artifacts. Do
+# we need this?
+# See also: https://github.com/apache/arrow/issues/22021
+if [ "${ARROW_JAVA_SHADE_FLATBUFFERS:-OFF}" == "ON" ]; then
Review Comment:
Yes, we can use #67!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-537: [Release][Docs] Generate API reference [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #538:
URL: https://github.com/apache/arrow-java/pull/538#discussion_r1921980422
##########
.github/workflows/rc.yml:
##########
Review Comment:
Ah, yes, vcpkg-jni only builds the shared object and not the full package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-537: [Release][Docs] Generate API reference [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #538:
URL: https://github.com/apache/arrow-java/pull/538#issuecomment-2601238966
BTW, I will try to migrate the Sphinx docs when I get a chance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-537: [Release][Docs] Generate API reference [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #538:
URL: https://github.com/apache/arrow-java/pull/538#issuecomment-2601790159
I confirmed that `release-docs` includes API reference for JNI such as C and Gandiva: https://github.com/apache/arrow-java/actions/runs/12863727769?pr=538#artifacts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-537: [Release][Docs] Generate API reference [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #538:
URL: https://github.com/apache/arrow-java/pull/538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-537: [Release][Docs] Generate API reference [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #538:
URL: https://github.com/apache/arrow-java/pull/538#discussion_r1921973982
##########
.github/workflows/rc.yml:
##########
Review Comment:
I thought we can use `docker compose run vcpkg-jni` but it doesn't create JAR. So I can't use it for `mvn site`.
I used `ci/scripts/jni_full_build.sh` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-537: [Release][Docs] Generate API reference [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #538:
URL: https://github.com/apache/arrow-java/pull/538#discussion_r1921736621
##########
ci/scripts/build.sh:
##########
@@ -61,27 +59,38 @@ done
pushd "${build_dir}"
-if [ "${ARROW_JAVA_SHADE_FLATBUFFERS}" == "ON" ]; then
+# TODO: ARROW_JAVA_SHADE_FLATBUFFERS isn't used for our artifacts. Do
+# we need this?
+# See also: https://github.com/apache/arrow/issues/22021
+if [ "${ARROW_JAVA_SHADE_FLATBUFFERS:-OFF}" == "ON" ]; then
Review Comment:
OK. Can we use #67 for this topic? Or should we create a separated issue for this topic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-537: [Release][Docs] Generate API reference [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #538:
URL: https://github.com/apache/arrow-java/pull/538#discussion_r1921732334
##########
.github/workflows/rc.yml:
##########
Review Comment:
Does this build the docs for the JNI components too? Or do we need to enable the JNI build to get the Javadocs?
##########
ci/scripts/build.sh:
##########
@@ -61,27 +59,38 @@ done
pushd "${build_dir}"
-if [ "${ARROW_JAVA_SHADE_FLATBUFFERS}" == "ON" ]; then
+# TODO: ARROW_JAVA_SHADE_FLATBUFFERS isn't used for our artifacts. Do
+# we need this?
+# See also: https://github.com/apache/arrow/issues/22021
+if [ "${ARROW_JAVA_SHADE_FLATBUFFERS:-OFF}" == "ON" ]; then
Review Comment:
I think we need to revisit this sometime because of https://github.com/apache/arrow-java/issues/67 (and it appears Google has closed the issue asking them to fix it upstream).
AFAIK the discussion in the issue you found is weird...We shouldn't need to change imports ourselves, the shading should take care of that. But that's not relevant here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-537: [Release][Docs] Generate API reference [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #538:
URL: https://github.com/apache/arrow-java/pull/538#discussion_r1921735826
##########
.github/workflows/rc.yml:
##########
Review Comment:
> Does this build the docs for the JNI components too?
No.
> Or do we need to enable the JNI build to get the Javadocs?
Yes. But it's easy because we already have JNI enabled jobs. I'll do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org