You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/24 04:52:43 UTC
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6431: Fix alarm httpclient connection leak
codecov[bot] edited a comment on pull request #6431:
URL: https://github.com/apache/skywalking/pull/6431#issuecomment-784759581
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=h1) Report
> Merging [#6431](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=desc) (700fa56) into [master](https://codecov.io/gh/apache/skywalking/commit/1c52995cbf26fa1442ba6b81fb3c4635625e3702?el=desc) (1c52995) will **decrease** coverage by `16.25%`.
> The diff coverage is `32.89%`.
[](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6431 +/- ##
=============================================
- Coverage 56.82% 40.57% -16.26%
+ Complexity 3970 2502 -1468
=============================================
Files 985 831 -154
Lines 24397 20407 -3990
Branches 2401 1928 -473
=============================================
- Hits 13864 8280 -5584
- Misses 9305 11475 +2170
+ Partials 1228 652 -576
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-46.43%)` | `2.00 <0.00> (-2.00)` | |
| [.../alarm/provider/dingtalk/DingtalkHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9kaW5ndGFsay9EaW5ndGFsa0hvb2tDYWxsYmFjay5qYXZh) | `16.98% <0.00%> (-1.89%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/feishu/FeishuHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9mZWlzaHUvRmVpc2h1SG9va0NhbGxiYWNrLmphdmE=) | `12.85% <0.00%> (-1.43%)` | `2.00 <0.00> (-1.00)` | |
| [...r/core/alarm/provider/slack/SlackhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9zbGFjay9TbGFja2hvb2tDYWxsYmFjay5qYXZh) | `20.83% <0.00%> (-4.75%)` | `2.00 <0.00> (-1.00)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <0.00%> (-2.64%)` | `2.00 <0.00> (-1.00)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| ... and [390 more](https://codecov.io/gh/apache/skywalking/pull/6431/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=footer). Last update [665a07c...b7520a5](https://codecov.io/gh/apache/skywalking/pull/6431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org