You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ma...@apache.org on 2014/08/30 00:09:14 UTC
android commit: CB-7410 fix the menu test
Repository: cordova-android
Updated Branches:
refs/heads/master 07632b0ee -> 0cde8819c
CB-7410 fix the menu test
Need to show the title in order for the options menu button to be visible.
Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/0cde8819
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/0cde8819
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/0cde8819
Branch: refs/heads/master
Commit: 0cde8819cfdfa7df03639b9d3b24f7d2933dee1a
Parents: 07632b0
Author: Marcel Kinard <cm...@gmail.com>
Authored: Fri Aug 29 18:07:29 2014 -0400
Committer: Marcel Kinard <cm...@gmail.com>
Committed: Fri Aug 29 18:07:29 2014 -0400
----------------------------------------------------------------------
test/assets/www/menus/index.html | 2 +-
test/src/org/apache/cordova/test/menus.java | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-android/blob/0cde8819/test/assets/www/menus/index.html
----------------------------------------------------------------------
diff --git a/test/assets/www/menus/index.html b/test/assets/www/menus/index.html
index 58d64c3..ff0b93b 100755
--- a/test/assets/www/menus/index.html
+++ b/test/assets/www/menus/index.html
@@ -33,7 +33,7 @@
<h4>Deviceready: <span id="deviceready"> </span></h4>
</div>
<div id="info">
- <h4>The menu items should be:</h4>
+ <h4>The options menu items should be:</h4>
<li>Item1<br>
<li>Item2<br>
<li>Item3<br>
http://git-wip-us.apache.org/repos/asf/cordova-android/blob/0cde8819/test/src/org/apache/cordova/test/menus.java
----------------------------------------------------------------------
diff --git a/test/src/org/apache/cordova/test/menus.java b/test/src/org/apache/cordova/test/menus.java
index 12d5230..6d0d3f1 100755
--- a/test/src/org/apache/cordova/test/menus.java
+++ b/test/src/org/apache/cordova/test/menus.java
@@ -28,10 +28,12 @@ import android.view.ContextMenu.ContextMenuInfo;
import org.apache.cordova.*;
import org.apache.cordova.LOG;
-public class menus extends DroidGap {
+public class menus extends CordovaActivity {
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
+ // need the title to be shown for the options menu to be visible
+ preferences.set("showTitle", true);
super.init();
super.registerForContextMenu(super.appView);
super.loadUrl("file:///android_asset/www/menus/index.html");