You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/02/25 21:08:03 UTC
[GitHub] mcvsubbu commented on a change in pull request #3877: Pinot
controller side change to enhance LLC segment metadata upload.
mcvsubbu commented on a change in pull request #3877: Pinot controller side change to enhance LLC segment metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3877#discussion_r260017970
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/protocols/SegmentCompletionProtocol.java
##########
@@ -200,6 +203,7 @@ public String getUrl(String hostPort, String protocol) {
private String _segmentLocation;
private long _memoryUsedBytes;
private long _segmentSizeBytes;
+ private SegmentMetadata _segmentMetadata;
Review comment:
You should not be sending segment metadata as a query parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org