[GitHub] [nuttx] radek-pesina commented on a diff in pull request #9119: Fix missing instantiation of return value in rwb_mediaremoved.

["radek-pesina (via GitHub)" <gi...@apache.org>]

radek-pesina commented on code in PR #9119:
URL: https://github.com/apache/nuttx/pull/9119#discussion_r1178671507


##########
drivers/misc/rwbuffer.c:
##########
@@ -1210,7 +1212,7 @@ int rwb_mediaremoved(FAR struct rwbuffer_s *rwb)
     }
 #endif
 
-  return OK;
+  return ret;

Review Comment:
   Styling in this file applies both therefore was not sure which way to apply.  e.g. refer to rwb_write().  If required can change to style of function below as opposed to function above.



##########
drivers/misc/rwbuffer.c:
##########
@@ -1182,6 +1182,8 @@ ssize_t rwb_readbytes(FAR struct rwbuffer_s *dev, off_t offset,
 #ifdef CONFIG_DRVR_REMOVABLE
 int rwb_mediaremoved(FAR struct rwbuffer_s *rwb)
 {
+  int ret = OK;

Review Comment:
   Styling in this file applies both therefore was not sure which way to apply.  e.g. refer to rwb_write().  If required can change to style of function below as opposed to function above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org