You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/12 05:05:15 UTC
[GitHub] [incubator-tvm] zhiics opened a new pull request #5786: [DOC][FIX] Fix some typos in git-clang-format.sh
zhiics opened a new pull request #5786:
URL: https://github.com/apache/incubator-tvm/pull/5786
Fix some typos in the error message of git-clang-format.
cc @tqchen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5786: [DOC][FIX] Fix some typos in git-clang-format.sh
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #5786:
URL: https://github.com/apache/incubator-tvm/pull/5786#issuecomment-643149477
Off the topic, sometimes we may fail clang format, which surprisingly won’t stop windows/macos build. So it is probably better to migrate clang format check to github actions CI to prevent useless builds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #5786: [DOC][FIX] Fix some typos in git-clang-format.sh
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5786:
URL: https://github.com/apache/incubator-tvm/pull/5786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5786: [DOC][FIX] Fix some typos in git-clang-format.sh
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5786:
URL: https://github.com/apache/incubator-tvm/pull/5786#issuecomment-643331606
Thanks @zhiics . The git action CI is relatively cheaper so it is fine to just keep it as it is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org