You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/19 12:07:28 UTC
[GitHub] [superset] codecov[bot] commented on pull request #21136: chore: refactor FilterableTable to functional component
codecov[bot] commented on PR #21136:
URL: https://github.com/apache/superset/pull/21136#issuecomment-1220598189
# [Codecov](https://codecov.io/gh/apache/superset/pull/21136?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21136](https://codecov.io/gh/apache/superset/pull/21136?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41c14b9) into [master](https://codecov.io/gh/apache/superset/commit/642a0d77042e9350d92e3f35e99cfd24937a23b9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (642a0d7) will **increase** coverage by `0.06%`.
> The diff coverage is `74.28%`.
> :exclamation: Current head 41c14b9 differs from pull request most recent head 66b704c. Consider uploading reports for the commit 66b704c to get more accurate results
```diff
@@ Coverage Diff @@
## master #21136 +/- ##
==========================================
+ Coverage 66.26% 66.32% +0.06%
==========================================
Files 1772 1772
Lines 67649 67659 +10
Branches 7205 7212 +7
==========================================
+ Hits 44825 44877 +52
+ Misses 20981 20939 -42
Partials 1843 1843
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.10% <76.47%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/superset/pull/21136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `39.31% <0.00%> (-0.09%)` | :arrow_down: |
| [...-frontend/src/components/FilterableTable/index.tsx](https://codecov.io/gh/apache/superset/pull/21136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL2luZGV4LnRzeA==) | `72.34% <76.47%> (+2.34%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/21136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.75% <0.00%> (+0.23%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/21136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.32% <0.00%> (+0.52%)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/21136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `77.01% <0.00%> (+2.01%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/21136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `87.97% <0.00%> (+6.01%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org