[jira] [Comment Edited] (BIGTOP-1944) Upgrade Spark version to 1.5.1

["RJ Nowling (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941778#comment-14941778 ] 

RJ Nowling edited comment on BIGTOP-1944 at 10/2/15 9:23 PM:
-------------------------------------------------------------

Hi [~jonathak],

Thanks for the patch!  A few comments:

1. I can't review the Puppet bits because I don't have enough familiarity with them.  If you want to move the Puppet changes to a separate patch / JIRA, I can focus on reviewing the Spark update and RPM changes

2. I'm worried about compiling Spark with Ganglia, which is LPGL licensed.  Spark seems to need this to be explicitly enabled, and I'm wondering if we need to do the same as well.  (e.g., create an environmental variable or something and document it).  I'll send an email to the dev list to get feedback on this.

3. The patch has a number of changes that seem purely cosmetic (e.g., changing the order of the source imports in the RPM SPEC file, re-organized lines in spark-core.install, etc.).  These make the patch hard to read, and I don't want to accidentally introduce errors.  Can you clean those up?

Thanks!


was (Author: rnowling):
Hi [~jonathak],

Thanks for the patch!  A few comments:

1. I can't review the Puppet bits because I don't have enough familiarity with them.  If you want to move the Puppet changes to a separate patch / JIRA, I can focus on reviewing the Spark update and RPM changes

2. I'm worried about compiling Spark with Nagios, which is LPGL licensed.  Spark seems to need this to be explicitly enabled, and I'm wondering if we need to do the same as well.  (e.g., create an environmental variable or something and document it).  I'll send an email to the dev list to get feedback on this.

3. The patch has a number of changes that seem purely cosmetic (e.g., changing the order of the source imports in the RPM SPEC file, re-organized lines in spark-core.install, etc.).  These make the patch hard to read, and I don't want to accidentally introduce errors.  Can you clean those up?

Thanks!

> Upgrade Spark version to 1.5.1
> ------------------------------
>
>                 Key: BIGTOP-1944
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1944
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: spark
>    Affects Versions: 1.0.0
>            Reporter: YoungWoo Kim
>            Assignee: Jonathan Kelly
>             Fix For: 1.1.0
>
>
> Bump up Apache Spark version to 1.5.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)