[jira] [Commented] (HIVE-4472) OR, NOT Filter logic can lose an array, and always takes time O(VectorizedRowBatch.DEFAULT_SIZE)

["Eric Hanson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659757#comment-13659757 ] 

Eric Hanson commented on HIVE-4472:
-----------------------------------

I posted additional comments to review board. Patch is almost ready but not quite. Expect one more update from Jitendra.
                
> OR, NOT Filter logic can lose an array, and always takes time O(VectorizedRowBatch.DEFAULT_SIZE)
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-4472
>                 URL: https://issues.apache.org/jira/browse/HIVE-4472
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Eric Hanson
>            Assignee: Jitendra Nath Pandey
>         Attachments: HIVE-4472.1.patch, HIVE-4472.2.patch, HIVE-4472.3.patch
>
>
> The issue is in file FilterExprOrExpr.java and FilterNotExpr.java.
> I posted a review for you at 
> https://reviews.apache.org/r/10752/
> I think there is a bug related to sharing of an array of integers. Also, one algorithm step takes O(DEFAULT_BATCH_SIZE) time always. If n<<DEFAULT_BATCH_SIZE then this is a performance issue. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira