You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "jainankitk (via GitHub)" <gi...@apache.org> on 2024/09/03 15:47:55 UTC
[I] Move anonymous Weight implementation in PointRangeQuery to named class [lucene]
jainankitk opened a new issue, #13710:
URL: https://github.com/apache/lucene/issues/13710
### Description
The `Weight` implementation in `PointRangeQuery#createWeight` is anonymous class making it difficult to extend or reuse specific logic from the class. Not to mention the class being more ~400 lines of code which makes good case for named class anyways IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Move anonymous Weight implementation in PointRangeQuery to named class [lucene]
Posted by "ferizoozoo (via GitHub)" <gi...@apache.org>.
ferizoozoo commented on issue #13710:
URL: https://github.com/apache/lucene/issues/13710#issuecomment-5297582418
Hi @jainankitk can I make a contribution to this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Move anonymous Weight implementation in PointRangeQuery to named class [lucene]
Posted by "vijaykriishna (via GitHub)" <gi...@apache.org>.
vijaykriishna commented on issue #13710:
URL: https://github.com/apache/lucene/issues/13710#issuecomment-3368540873
Hello @jainankitk I've opened a PR for this task. Link is tagged to this issue. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [I] Move anonymous Weight implementation in PointRangeQuery to named class [lucene]
Posted by "jainankitk (via GitHub)" <gi...@apache.org>.
jainankitk commented on issue #13710:
URL: https://github.com/apache/lucene/issues/13710#issuecomment-3378599226
@vijaykriishna - I had PR for this - https://github.com/apache/lucene/pull/13711 open, but was unable to make further progress. Does your approach addresses the concerns raised by Adrien here - https://github.com/apache/lucene/pull/13711#issuecomment-2327425891?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org