[GitHub] [spark] gengliangwang commented on pull request #33665: [SPARK-36428][SQL] the seconds parameter of make_timestamp should accept integer type

[GitBox <gi...@apache.org>]

gengliangwang commented on pull request #33665:
URL: https://github.com/apache/spark/pull/33665#issuecomment-900169863


   I think we can change the accept type as `decimal(12,2)` instead, which is wider than the Integer type. So that we can get rid of the type collection and make the implementation simpler.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org