You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/23 10:27:40 UTC
[GitHub] [doris] dataroaring opened a new pull request, #11142: use suffix of directory as group name and use directory as dbname
dataroaring opened a new pull request, #11142:
URL: https://github.com/apache/doris/pull/11142
We can rename tpcds_sf1 to tpcds_sf1_p1, then tpcds_sf1 will be in group
p1. We will group cases to p0, p1, p2, p3 in the future.
p0: function cases running in seconds.
p1: cases with expected out running in minutes, like tpcds_sf1
p2: cases with expected out running in hours, like tpcds_sf10 tpcds_sf100
p3: cases without without expected out to test core dump.
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #11142: [test] use suffix of directory as group name and use directory as dbname
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #11142:
URL: https://github.com/apache/doris/pull/11142#discussion_r928122329
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/SuiteContext.groovy:
##########
@@ -34,6 +34,7 @@ class SuiteContext implements Closeable {
public final File file
public final String suiteName
public final String group
+ public final String dbName
Review Comment:
```suggestion
public final String dbNameSuffix
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #11142: [test] use suffix of directory as group name and use directory as dbname
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #11142:
URL: https://github.com/apache/doris/pull/11142#discussion_r928118543
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/Config.groovy:
##########
@@ -371,18 +371,20 @@ class Config {
return DriverManager.getConnection(jdbcUrl, jdbcUser, jdbcPassword)
}
- Connection getConnectionByLastGroup(String group) {
- String realDb = getDbByLastGroup(group)
- String dbUrl = buildUrl(realDb)
- tryCreateDbIfNotExist(realDb)
+ Connection getConnectionByDbName(String dbName) {
Review Comment:
```suggestion
Connection getConnectionByDbNameSuffix(String dbNameSuffix) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #11142: [test] use suffix of directory as group name and use directory as dbname
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #11142:
URL: https://github.com/apache/doris/pull/11142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org