You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/05 11:20:57 UTC
[GitHub] [pulsar] congbobo184 commented on a change in pull request #12590: Fix call sync method in an async callback when enabling geo replicator.
congbobo184 commented on a change in pull request #12590:
URL: https://github.com/apache/pulsar/pull/12590#discussion_r743577016
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1061,43 +1062,53 @@ public void deleteTopicAuthenticationWithRetry(String topic, CompletableFuture<V
}
final long topicCreateTimeMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime());
NonPersistentTopic nonPersistentTopic = new NonPersistentTopic(topic, this);
-
- CompletableFuture<Optional<Topic>> future = nonPersistentTopic.initialize()
- .thenCompose(__ -> nonPersistentTopic.checkReplication())
- .thenApply(__ -> {
- log.info("Created topic {}", nonPersistentTopic);
- long topicLoadLatencyMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime()) - topicCreateTimeMs;
- pulsarStats.recordTopicLoadTimeValue(topic, topicLoadLatencyMs);
- addTopicToStatsMaps(TopicName.get(topic), nonPersistentTopic);
- return Optional.of(nonPersistentTopic);
- });
-
- future.exceptionally((ex) -> {
- log.warn("Replication check failed. Removing topic from topics list {}, {}", topic, ex);
- nonPersistentTopic.stopReplProducers().whenComplete((v, exception) -> {
- pulsar.getExecutor().execute(() -> topics.remove(topic, future));
+ CompletableFuture<Void> isOwner = checkTopicNsOwnership(topic);
+ isOwner.thenRun(() -> {
+ nonPersistentTopic.initialize()
+ .thenCompose(__ -> nonPersistentTopic.checkReplication())
+ .thenRun(() -> {
+ log.info("Created topic {}", nonPersistentTopic);
+ long topicLoadLatencyMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime()) - topicCreateTimeMs;
+ pulsarStats.recordTopicLoadTimeValue(topic, topicLoadLatencyMs);
+ addTopicToStatsMaps(TopicName.get(topic), nonPersistentTopic);
+ topicFuture.complete(Optional.of(nonPersistentTopic));
+ }).exceptionally(ex -> {
+ log.warn("Replication check failed. Removing topic from topics list {}, {}", topic, ex.getCause());
+ nonPersistentTopic.stopReplProducers().whenComplete((v, exception) -> {
+ pulsar.getExecutor().execute(() -> topics.remove(topic, topicFuture));
+ topicFuture.completeExceptionally(ex);
Review comment:
No effect before and after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org