[GitHub] [iceberg] rdblue commented on a diff in pull request #6350: Spark 3.3: Time range query of changelog tables

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6350:
URL: https://github.com/apache/iceberg/pull/6350#discussion_r1054610098


##########
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##########
@@ -149,8 +149,7 @@ public static Iterable<Snapshot> ancestorsOf(long snapshotId, Function<Long, Sna
   }
 
   /**
-   * Traverses the history of the table's current snapshot and finds the first snapshot committed
-   * after the given time.
+   * Finds the oldest snapshot of a table that was committed either at or after a given time.

Review Comment:
   @flyrain, this change is incorrect. This is not the oldest known snapshot, it is the oldest known snapshot in the current snapshot's history. Can you fix it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org