You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by mars <gi...@git.apache.org> on 2017/06/16 18:50:06 UTC

[GitHub] incubator-predictionio pull request #393: Fix to show stacktrace for errors ...

GitHub user mars opened a pull request:

    https://github.com/apache/incubator-predictionio/pull/393

    Fix to show stacktrace for errors thrown in `queries.json` REST API

    We were getting intractable errors from `queries.json` requests, like this one without a stacktrace:
    
    ```
    [ERROR] [ServerActor] Query '{
      "user": "000",
      "item": "000"
    }' is invalid. Reason: Expected object but got JNothing
    ```
    
    This pull request adds stacktraces to these errors using the pattern already present elsewhere in `CreateServer.scala`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mars/incubator-predictionio log-queries-stacktrace

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio/pull/393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #393
    
----
commit f50980d6513c367657374988083e32039c454992
Author: Mars Hall <ma...@heroku.com>
Date:   2017-06-16T18:45:03Z

    Fix to show stacktrace for errors thrown in `queries.json` REST API

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio pull request #393: [PIO-94] Fix to show stacktrace fo...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-predictionio/pull/393


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #393: [PIO-94] Fix to show stacktrace for error...

Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/393
  
    LGTM. Thanks @mars !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---