You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "surnaik (via GitHub)" <gi...@apache.org> on 2025/06/02 04:49:17 UTC
[PR] [VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
surnaik opened a new pull request, #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828
Currently, when we build Velox with tests on
./dev/buildbundle-veloxbe.sh --build_type=Debug --build_tests=ON --enable_gcs=ON --enable_hdfs=ON --build_velox_tests=ON --spark_version=3.5
The tests fail to build with the following error
CMake Error at velox/buffer/tests/CMakeLists.txt:18 (target_link_libraries):
Target "velox_buffer_test" links to:
GTest::gmock
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
I reinstalled googletest as well, but it still couldn't resolve gmock. I was able to get it working after using the BUNDLED GTest.
## What changes were proposed in this pull request?
Set GTest_SOURCE=BUNDLED
## How was this patch tested?
Existing UTs and Build pipelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "surnaik (via GitHub)" <gi...@apache.org>.
surnaik commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-2929379623
@PHILO-HE could you please take a look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "surnaik (via GitHub)" <gi...@apache.org>.
surnaik commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-2928752120
@zhouyuan Can you please take a look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "surnaik (via GitHub)" <gi...@apache.org>.
surnaik commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-2933282060
I’m using Ubuntu 22.04
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-3130329278
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-2933239588
@surnaik, this seems not a fix for the root cause. It would be better to also make pre-installed gtest work. Could you tell me which OS you are using?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #9828: [BUILD][VL] Fix velox test build breaking due to GMock missing in System library
URL: https://github.com/apache/incubator-gluten/pull/9828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-2933501758
@surnaik, I note you are not enabling vcpkg. Then, the dependency libs can be pre-installed by setup scripts. According to the script below, you can try to install libgtest-dev & libgmock-dev to see if it works.
https://github.com/facebookincubator/velox/blob/main/scripts/setup-ubuntu.sh#L121-L122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "surnaik (via GitHub)" <gi...@apache.org>.
surnaik commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-2933347952
> I just tried using apache/gluten:vcpkg-centos-8 to build tests. Static version works well.
Thanks, let me give a try. I currently only use Ubuntu or a Debian based custom OS, could be a system issue on my side as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-2938059813
@surnaik for dynamic link, you need to run `--run_setup_script=ON` at least once on a fresh system, which install all depencency libraries into your system. In following build you can set `--run_setup_script=OFF`
https://github.com/apache/incubator-gluten/blob/33ce2edfaba5f562117c9fbec5d94405f6cea334/dev/docker/Dockerfile.centos8-dynamic-build#L55C4-L55C66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-3091392022
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-2928737283
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-2933310844
I just tried using apache/gluten:vcpkg-centos-8 to build tests. Static version works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [BUILD][VL] Fix velox test build breaking due to GMock missing in System library [incubator-gluten]
Posted by "surnaik (via GitHub)" <gi...@apache.org>.
surnaik commented on PR #9828:
URL: https://github.com/apache/incubator-gluten/pull/9828#issuecomment-2933429561
@FelixYBW That worked for me as well, but on Ubuntu 22.04, I rebuilt the googletest library as well, but somehow it's not able to still resolve GMock, I'll give this a try to find the reason later as I'm able to workaround using BUNDLED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org