[jira] [Commented] (COUCHDB-3337) End-point _local_docs doesn't conform to query params of _all_docs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935485#comment-15935485 ] 

ASF GitHub Bot commented on COUCHDB-3337:
-----------------------------------------

GitHub user eiri opened a pull request:

    https://github.com/apache/couchdb-couch-mrview/pull/72

    Fix  end-point _local_docs

    This fixes the following issues with `/{db}/_local_docs` end-point:
    
    1. Query ignores `include_docs` parameter
    1. Query reports incorrect `total_rows` value, returning total rows for non-local docs instead
    1. Query crashes with `badrecord` when trying to skip records, e.g. when `start_key` not the first local doc
    
    COUCHDB-3337

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch-mrview 84617-fix-_local_docs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch-mrview/pull/72.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #72
    
----
commit 021e46ad2792460e968021de84d42a8f3faa5f4d
Author: Eric Avdey <ei...@eiri.ca>
Date:   2017-03-17T14:04:53Z

    Make _local_docs conform to include_docs

commit 6867449cce3618a065f8c966c65a391d42e35283
Author: Eric Avdey <ei...@eiri.ca>
Date:   2017-03-21T15:03:09Z

    Adopt all_docs_reduce_to_count/1 to _local docs
    
    We are using all_docs_reduce_to_count/1 in
    _local_docs handler, but reductions got
    from local btree are different from
    reductions passed from id btree's enumerator.
    
    This change converts passed local's KVs to
    list of expected #doc_full_info records.

commit 79ad8bd1bf52c363334a5e55c627f46109d494bf
Author: Eric Avdey <ei...@eiri.ca>
Date:   2017-03-21T19:49:24Z

    Fix total_row for _local_docs

commit beaa1bab96c8876dce1e49a91a59041556c789ec
Author: Eric Avdey <ei...@eiri.ca>
Date:   2017-03-21T22:37:08Z

    Add utests for _local_docs

----


> End-point _local_docs doesn't conform to query params of _all_docs
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-3337
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-3337
>             Project: CouchDB
>          Issue Type: Bug
>            Reporter: Eric Avdey
>            Assignee: Eric Avdey
>
> There are following issues with {{/db/_local_doc end-point}}
> # It ignores include_docs parameter
> # It reports incorrect total_rows value, returning total rows of non-local docs instead
> # It crashes with {{badrecord}} {{full_doc_info}} when query trying to skip records



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)