You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/06/04 16:28:21 UTC

[PR] ci: stable required-check anchors for skippable matrix test jobs [superset]

rusackas opened a new pull request, #40772:
URL: https://github.com/apache/superset/pull/40772

   ### SUMMARY
   
   Follow-up to #40770. Frontend-only PRs (e.g. Dependabot npm bumps like #40757)
   are still blocked from merging — stuck on **`unit-tests (current)`** and
   **`test-postgres (current)`** showing *"Expected — Waiting for status to be
   reported."*
   
   **Root cause:** #40718 moved `unit-tests` and `test-postgres` to **job-level**
   change-detection gating (`if: needs.changes.outputs.python == 'true'`). On a
   non-Python PR the job is skipped — and a job-level skip happens **before matrix
   expansion**, so the per-combination contexts `unit-tests (current)` /
   `test-postgres (current)` are **never created**. Branch protection requires
   them, so the PR waits forever.
   
   This only bites *matrix* jobs. Non-matrix gated jobs (`test-mysql`,
   `test-sqlite`) publish a `skipped` check that branch protection treats as
   success — which is why only the two matrix contexts were stuck.
   
   **Fix:** add an always-running `*-required` anchor job for each matrix job that
   passes when the underlying job is `success` **or** `skipped`, and fails only on
   a real failure. Point the required status checks at those anchors:
   
   ```yaml
     unit-tests-required:
       needs: [changes, unit-tests]
       if: always()
       steps:
         - run: |
             [ "$RESULT" = success ] || [ "$RESULT" = skipped ] || exit 1
           env: { RESULT: "${{ needs.unit-tests.result }}" }
   ```
   
   `.asf.yaml`: `unit-tests (current)` → `unit-tests-required`, `test-postgres
   (current)` → `test-postgres-required`. The expensive matrix jobs stay **fully
   skipped** on unrelated PRs (no wasted Postgres/Redis service containers); the
   anchor is a ~5-second no-op.
   
   > 📝 Related follow-up: #40722 (Python matrix → current-only on PRs) will stop
   > producing `pre-commit (previous)` on PRs. That's a *matrix reduction*, not a
   > job-skip, so it just needs the `pre-commit (previous)` context removed from
   > `.asf.yaml` — handled in that PR, no shim required.
   
   ### TESTING INSTRUCTIONS
   
   - Python PR: `unit-tests-required` / `test-postgres-required` run after the
     matrix jobs and pass.
   - Frontend-only / docs PR: the matrix jobs skip; the anchors run and pass; the
     PR is mergeable.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] ci: stable required-check anchors for skippable matrix test jobs [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.

bito-code-review[bot] commented on PR #40772:
URL: https://github.com/apache/superset/pull/40772#issuecomment-4624196633

   <!-- Bito Reply -->
   This pull request introduces stable "required" status check anchors for the `test-postgres` and `unit-tests` jobs in the GitHub Actions workflows. 
   
   Because the original matrix-based jobs are gated on change detection, they are skipped on non-Python PRs, which can cause branch protection checks to fail. The new `test-postgres-required` and `unit-tests-required` jobs are configured to run `always()`, checking the result of the original jobs and passing if they either succeeded or were skipped, ensuring branch protection requirements are consistently met.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] ci: stable required-check anchors for skippable matrix test jobs [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.

hainenber commented on PR #40772:
URL: https://github.com/apache/superset/pull/40772#issuecomment-4624183188

   Thanks Evan, LGreatTM :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org