You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/06/03 00:39:15 UTC
[GitHub] [pinot] shenyu0127 opened a new pull request, #10839: Make DistinctTable consume OrderByExpressionContext::isNullsLast.
shenyu0127 opened a new pull request, #10839:
URL: https://github.com/apache/pinot/pull/10839
This PR makes `SELECT DISTINCT` handle NULL ordering correctly.
Tested in unit tests and local server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10839: Make DistinctTable consume OrderByExpressionContext::isNullsLast.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10839:
URL: https://github.com/apache/pinot/pull/10839#issuecomment-1574533773
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10839](https://app.codecov.io/gh/apache/pinot/pull/10839?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (23befd6) into [master](https://app.codecov.io/gh/apache/pinot/commit/87379fc6411a928b18d5ee8f6ec4a07f5cd0f8d3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (87379fc) will **decrease** coverage by `3.02%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #10839 +/- ##
============================================
- Coverage 27.09% 24.08% -3.02%
+ Complexity 58 49 -9
============================================
Files 2154 2154
Lines 116255 116257 +2
Branches 17606 17607 +1
============================================
- Hits 31495 27995 -3500
- Misses 81619 85302 +3683
+ Partials 3141 2960 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.08% <50.00%> (+0.25%)` | :arrow_up: |
| integration2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/pinot/core/query/distinct/DistinctTable.java](https://app.codecov.io/gh/apache/pinot/pull/10839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9EaXN0aW5jdFRhYmxlLmphdmE=) | `43.22% <50.00%> (+0.07%)` | :arrow_up: |
... and [278 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10839/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10839: Make DistinctTable consume OrderByExpressionContext::isNullsLast.
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10839:
URL: https://github.com/apache/pinot/pull/10839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org