You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2023/02/24 08:28:49 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1513: MINIFICPP-2053 Reduce CentOS image size in CI build
lordgamez opened a new pull request, #1513:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1513
It started to occur that the CentOS build exceeded the 14GB disk space Github Actions VMs provide. JDK and the packaged tar.gz are removed from the CI build and JNI and SFTP builds are moved to the ubuntu build. This reduces the image size by about 2GBs.
https://issues.apache.org/jira/browse/MINIFICPP-2053
------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1513: MINIFICPP-2053 Reduce CentOS image size in CI build
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1513:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1513#discussion_r1124237256
##########
docker/bionic/Dockerfile:
##########
@@ -21,6 +21,7 @@ FROM ubuntu:bionic AS build_deps
LABEL maintainer="Apache NiFi <de...@nifi.apache.org>"
ARG MINIFI_VERSION
+ARG DOCKER_MAKE_COMMAND=""
Review Comment:
Good point, update in a2dfe54a6f67485d5c683775cf03b753faedb44b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1513: MINIFICPP-2053 Reduce CentOS image size in CI build
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #1513: MINIFICPP-2053 Reduce CentOS image size in CI build
URL: https://github.com/apache/nifi-minifi-cpp/pull/1513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1513: MINIFICPP-2053 Reduce CentOS image size in CI build
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1513:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1513#discussion_r1124162265
##########
docker/bionic/Dockerfile:
##########
@@ -21,6 +21,7 @@ FROM ubuntu:bionic AS build_deps
LABEL maintainer="Apache NiFi <de...@nifi.apache.org>"
ARG MINIFI_VERSION
+ARG DOCKER_MAKE_COMMAND=""
Review Comment:
This should be `DOCKER_MAKE_TARGET`, instead of `DOCKER_MAKE_COMMAND`.
Also, I would prefer to make the default make target `"all"`, instead of `""` implicitly defaulting to `"all"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org