You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/12/17 03:22:50 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4932: Misc fix for
pinot spi
codecov-io commented on issue #4932: Misc fix for pinot spi
URL: https://github.com/apache/incubator-pinot/pull/4932#issuecomment-566362843
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4932?src=pr&el=h1) Report
> Merging [#4932](https://codecov.io/gh/apache/incubator-pinot/pull/4932?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/08c0c2b20e71e6dd44ffba6ceae190a7afd4c8eb?src=pr&el=desc) will **increase** coverage by `20.47%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4932?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4932 +/- ##
=============================================
+ Coverage 36.14% 56.61% +20.47%
- Complexity 0 53 +53
=============================================
Files 1177 1177
Lines 62857 62857
Branches 9222 9222
=============================================
+ Hits 22718 35586 +12868
+ Misses 38120 24623 -13497
- Partials 2019 2648 +629
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4932?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/pinot/json/data/readers/JSONRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4932/diff?src=pr&el=tree#diff-cGlub3QtcmVjb3JkLXJlYWRlcnMvcGlub3QtanNvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvanNvbi9kYXRhL3JlYWRlcnMvSlNPTlJlY29yZFJlYWRlci5qYXZh) | `90% <ø> (ø)` | `12 <0> (?)` | |
| [.../thrift/data/readers/ThriftRecordReaderConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4932/diff?src=pr&el=tree#diff-cGlub3QtcmVjb3JkLXJlYWRlcnMvcGlub3QtdGhyaWZ0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90aHJpZnQvZGF0YS9yZWFkZXJzL1RocmlmdFJlY29yZFJlYWRlckNvbmZpZy5qYXZh) | `80% <ø> (ø)` | `3 <0> (?)` | |
| [.../pinot/csv/data/readers/CSVRecordReaderConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4932/diff?src=pr&el=tree#diff-cGlub3QtcmVjb3JkLXJlYWRlcnMvcGlub3QtY3N2L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jc3YvZGF0YS9yZWFkZXJzL0NTVlJlY29yZFJlYWRlckNvbmZpZy5qYXZh) | `56.25% <ø> (ø)` | `6 <0> (?)` | |
| [...apache/pinot/csv/data/readers/CSVRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4932/diff?src=pr&el=tree#diff-cGlub3QtcmVjb3JkLXJlYWRlcnMvcGlub3QtY3N2L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jc3YvZGF0YS9yZWFkZXJzL0NTVlJlY29yZFJlYWRlci5qYXZh) | `74.07% <ø> (ø)` | `15 <0> (?)` | |
| [.../pinot/thrift/data/readers/ThriftRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4932/diff?src=pr&el=tree#diff-cGlub3QtcmVjb3JkLXJlYWRlcnMvcGlub3QtdGhyaWZ0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC90aHJpZnQvZGF0YS9yZWFkZXJzL1RocmlmdFJlY29yZFJlYWRlci5qYXZh) | `81.48% <ø> (ø)` | `13 <0> (?)` | |
| [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4932/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `57.69% <0%> (-21.8%)` | `0% <0%> (ø)` | |
| [...he/pinot/controller/util/SegmentIntervalUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4932/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL1NlZ21lbnRJbnRlcnZhbFV0aWxzLmphdmE=) | `0% <0%> (-8.34%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4932/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `58.06% <0%> (-7.53%)` | `0% <0%> (ø)` | |
| [...ng/builder/DefaultRealtimeRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4932/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0RlZmF1bHRSZWFsdGltZVJvdXRpbmdUYWJsZUJ1aWxkZXIuamF2YQ==) | `61.9% <0%> (-4.77%)` | `0% <0%> (ø)` | |
| [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4932/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `81.96% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [584 more](https://codecov.io/gh/apache/incubator-pinot/pull/4932/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4932?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4932?src=pr&el=footer). Last update [08c0c2b...9bb1a29](https://codecov.io/gh/apache/incubator-pinot/pull/4932?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org