You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "michallenc (via GitHub)" <gi...@apache.org> on 2025/02/17 13:54:02 UTC
[PR] samv7/pwm: add support for latched fault inputs [nuttx]
michallenc opened a new pull request, #15850:
URL: https://github.com/apache/nuttx/pull/15850
## Summary
This adds configuration option for every fault input, that can be latched (kept even after the input value is below the threshold) or volatile (PWM is automatically enabled once the output polarity goes back to the normal state).
## Impact
Fault inputs on SAMv7 PWM can now be configured as non volatile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] samv7/pwm: add support for latched fault inputs [nuttx]
Posted by "michallenc (via GitHub)" <gi...@apache.org>.
michallenc commented on code in PR #15850:
URL: https://github.com/apache/nuttx/pull/15850#discussion_r1958409659
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -857,6 +857,14 @@ config SAMV7_PWM0_PA9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PA9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
Review Comment:
Yes, that looks more comprehensible, changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] samv7/pwm: add support for latched fault inputs [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #15850:
URL: https://github.com/apache/nuttx/pull/15850#issuecomment-2663207498
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
Yes, this PR appears to mostly meet the NuttX requirements, but it is missing some crucial information.
Here's a breakdown of what's missing and how to improve it:
* **Summary:** While it explains *what* the change does, it lacks the *why*. Is this addressing a specific issue users were facing? Does it improve performance or robustness? A more compelling summary would explain the motivation behind the change. Also, link any related NuttX issues.
* **Impact:** While it mentions the user impact, it needs more detail. Specifically:
* **Impact on user (YES):** How will users enable this new configuration option? Will they need to modify their device tree or configuration files? Provide clear instructions.
* **Impact on build (Possibly YES):** Does this introduce any new Kconfig options? If so, describe them.
* **Impact on hardware (YES):** This explicitly affects the SAMv7. State this clearly. Are other architectures impacted at all (even indirectly)?
* **Impact on documentation (YES):** Documentation *must* be updated to reflect this new configuration option. Mention that this update is included in the PR or will be provided in a separate PR.
* **Impact on security, compatibility:** While likely "NO" in this case, explicitly stating "NO" with a brief justification (e.g., "NO - This change only affects PWM configuration and does not introduce any new security vulnerabilities.") is better than leaving them blank.
* **Testing:** This section is completely empty. Provide details about your testing environment and *actual* logs demonstrating the change's behavior before and after. This is critical for reviewers to assess the correctness and stability of the change. Include the specific commands used for testing.
**In short:** The PR needs more context, details on user impact and build changes, confirmation of documentation updates, explicit "NO" answers with brief justifications where applicable, and, most importantly, actual testing logs and procedures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] samv7/pwm: add support for latched fault inputs [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #15850:
URL: https://github.com/apache/nuttx/pull/15850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] samv7/pwm: add support for latched fault inputs [nuttx]
Posted by "hartmannathan (via GitHub)" <gi...@apache.org>.
hartmannathan commented on code in PR #15850:
URL: https://github.com/apache/nuttx/pull/15850#discussion_r1958337862
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -872,6 +880,14 @@ config SAMV7_PWM0_PD8_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD8_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM0_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM0_PMC
+
+config SAMV7_PWM0_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM1_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM1_PMC
+
+config SAMV7_PWM1_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM1_AFEC0
+
+config SAMV7_PWM1_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM1_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM1_PMC
+
+config SAMV7_PWM1_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM1_AFEC0
+
+config SAMV7_PWM1_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM1_AFEC1
+
+config SAMV7_PWM1_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM1_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM1_PMC
+
+config SAMV7_PWM1_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM0_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM0_PMC
+
+config SAMV7_PWM0_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM0_AFEC0
+
+config SAMV7_PWM0_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM0_AFEC1
+
+config SAMV7_PWM0_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM1_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM1_PMC
+
+config SAMV7_PWM1_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM1_AFEC0
+
+config SAMV7_PWM1_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM1_AFEC1
+
+config SAMV7_PWM1_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_ACC
bool "External fault input from ACC"
default n
+if SAMV7_PWM1_ACC
+
+config SAMV7_PWM1_ACC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_TIM0
bool "External fault input from Timer 0"
default n
-endmenu
+if SAMV7_PWM1_TIM0
+config SAMV7_PWM1_TIM0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1118,6 +1202,14 @@ config SAMV7_PWM1_PA21_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA21_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM0_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM0_PMC
+
+config SAMV7_PWM0_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM0_AFEC0
+
+config SAMV7_PWM0_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM0_AFEC1
+
+config SAMV7_PWM0_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_ACC
bool "External fault input from ACC"
default n
+if SAMV7_PWM0_ACC
+
+config SAMV7_PWM0_ACC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM0_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM0_PMC
+
+config SAMV7_PWM0_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM0_AFEC0
+
+config SAMV7_PWM0_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -857,6 +857,14 @@ config SAMV7_PWM0_PA9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PA9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
Review Comment:
At minimum (extraneous `s` in `options`):
```suggestion
This option ensures the fault input remains active until it is cleared
```
Perhaps for clarity:
```suggestion
When this option is selected, the fault input remains active until it
is cleared by the software. When this option is not selected, the
fault is cleared once the fault input changes its polarity level back
to normal state.
```
WDYT?
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1133,6 +1225,14 @@ config SAMV7_PWM1_PA26_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA26_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM1_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM1_PMC
+
+config SAMV7_PWM1_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM1_AFEC0
+
+config SAMV7_PWM1_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM1_AFEC1
+
+config SAMV7_PWM1_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_ACC
bool "External fault input from ACC"
default n
+if SAMV7_PWM1_ACC
+
+config SAMV7_PWM1_ACC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM0_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM0_PMC
+
+config SAMV7_PWM0_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM0_AFEC0
+
+config SAMV7_PWM0_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM0_AFEC1
+
+config SAMV7_PWM0_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_ACC
bool "External fault input from ACC"
default n
+if SAMV7_PWM0_ACC
+
+config SAMV7_PWM0_ACC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
+ by the software. Otherwise, the fault is cleared once the fault input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_TIM0
bool "External fault input from Timer 0"
default n
+if SAMV7_PWM0_TIM0
+
+config SAMV7_PWM0_TIM0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is cleared
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] samv7/pwm: add support for latched fault inputs [nuttx]
Posted by "michallenc (via GitHub)" <gi...@apache.org>.
michallenc commented on code in PR #15850:
URL: https://github.com/apache/nuttx/pull/15850#discussion_r1958411294
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -872,6 +880,14 @@ config SAMV7_PWM0_PD8_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD8_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is cleared
Review Comment:
Ups, copy-paste mistake hell :sweat_smile: All fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] samv7/pwm: add support for latched fault inputs [nuttx]
Posted by "michallenc (via GitHub)" <gi...@apache.org>.
michallenc commented on PR #15850:
URL: https://github.com/apache/nuttx/pull/15850#issuecomment-2676762715
@acassis @hartmannathan Hi, is it ok to merge now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] samv7/pwm: add support for latched fault inputs [nuttx]
Posted by "hartmannathan (via GitHub)" <gi...@apache.org>.
hartmannathan commented on PR #15850:
URL: https://github.com/apache/nuttx/pull/15850#issuecomment-2664232435
> @hartmannathan PTAL
@acassis ok I'll take a look in a little while...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] samv7/pwm: add support for latched fault inputs [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #15850:
URL: https://github.com/apache/nuttx/pull/15850#issuecomment-2664087037
@hartmannathan PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org