You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/06 13:35:27 UTC

[GitHub] jinhuang415 commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

jinhuang415 commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization
URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193410215
 
 

 ##########
 File path: tests/python/quantization/test_quantization.py
 ##########
 @@ -319,6 +339,11 @@ def check_quantized_flatten(shape):
 
 @with_seed()
 def test_quantize_params():
+    if is_test_for_mkldnn():
+        dtype = 'uint8'
 
 Review comment:
   Currently MKLDNN quantization only support uint8 as input data so we made separate logic for mkldnn.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services