You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "geido (via GitHub)" <gi...@apache.org> on 2026/06/11 13:55:40 UTC
[PR] fix(deps): cap paramiko <4.0 to keep SSH tunneling working [superset]
geido opened a new pull request, #40973:
URL: https://github.com/apache/superset/pull/40973
### SUMMARY
[`paramiko` 4.0.0](https://www.paramiko.org/changelog.html) removed the `DSSKey` class (DSA support was dropped as obsolete and insecure). The [`sshtunnel`](https://pypi.org/project/sshtunnel/) library that Superset uses for SSH database tunneling still references `paramiko.DSSKey` **unconditionally** in its `get_keys()` helper, which `SSHTunnelForwarder.__init__` calls (via `_consolidate_auth`) on **every** `open_tunnel()`. Once `paramiko >= 4` is resolved into the environment, every SSH-tunneled database connection therefore fails during tunnel setup with:
```
AttributeError: module 'paramiko' has no attribute 'DSSKey'
```
This happens **regardless of the user's actual key type** (RSA, ed25519, …), because the crash occurs while enumerating key classes during forwarder initialization, before the user's key is ever used.
The dependency was declared as `paramiko>=3.4.0` with **no upper bound**, so any environment that re-resolves dependencies (fresh install / image rebuild) pulls `paramiko` 4.x/5.x and breaks. `sshtunnel` only requires `paramiko>=2.7.2` (also no upper bound) and its latest release (`0.4.0`) is unmaintained, so it does not constrain this either.
This PR caps the constraint to `paramiko>=3.4.0, <4.0`, keeping it on the 3.x line which retains `DSSKey`. The pinned lockfiles (`requirements/*.txt`) already resolve to `paramiko==3.5.1` (the latest 3.x), so **no lockfile regeneration is required** — and the cap prevents a future re-compile from silently floating to 4.x/5.x.
This is the same class of breakage other downstream projects hit after paramiko 4.0 (e.g. [pgadmin-org/pgadmin4#9090](https://github.com/pgadmin-org/pgadmin4/issues/9090), [paramiko/paramiko#2537](https://github.com/paramiko/paramiko/issues/2537)). The cap can be relaxed once `sshtunnel` (or a replacement) supports paramiko 4+.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — dependency constraint change.
### TESTING INSTRUCTIONS
With `paramiko < 4` resolved (current lock = `3.5.1`), the class `sshtunnel` needs is present:
```bash
python -c "import paramiko; assert hasattr(paramiko, 'DSSKey'); print('OK', paramiko.__version__)"
```
To observe the original failure, install `paramiko>=4` in an environment and attempt an SSH-tunneled database connection: `sshtunnel`'s `get_keys()` raises `AttributeError: module 'paramiko' has no attribute 'DSSKey'`. With this cap, dependency resolution keeps paramiko on 3.x and the tunnel opens normally.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(deps): cap paramiko <4.0 to keep SSH tunneling working [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido merged PR #40973:
URL: https://github.com/apache/superset/pull/40973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(deps): cap paramiko <4.0 to keep SSH tunneling working [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40973:
URL: https://github.com/apache/superset/pull/40973#issuecomment-4681364549
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40973?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.64%. Comparing base ([`2b18dc0`](https://app.codecov.io/gh/apache/superset/commit/2b18dc0a5c4b11bb86df71413911c5d302a8ff12?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d686221`](https://app.codecov.io/gh/apache/superset/commit/d6862213bd61226ad9c91503ac6f636d45924e3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
:x: Your project check has failed because the head coverage (99.95%) is below the target coverage (100.00%). You can increase the head coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage.
> :exclamation: There is a different number of reports uploaded between BASE (2b18dc0) and HEAD (d686221). Click for more details.
>
> <details><summary>HEAD has 51 uploads less than BASE</summary>
>
>| Flag | BASE (2b18dc0) | HEAD (d686221) |
>|------|------|------|
>|hive|7|1|
>|python|41|2|
>|presto|7|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40973 +/- ##
==========================================
- Coverage 64.30% 55.64% -8.67%
==========================================
Files 2657 2657
Lines 144028 144059 +31
Branches 33208 33216 +8
==========================================
- Hits 92612 80155 -12457
- Misses 49794 63187 +13393
+ Partials 1622 717 -905
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/40973/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/40973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.44% <ø> (-0.02%)` | :arrow_down: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/40973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/40973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/40973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.03% <ø> (-0.02%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/40973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.10% <ø> (-18.63%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/40973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/40973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/40973?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(deps): cap paramiko <4.0 to keep SSH tunneling working [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40973:
URL: https://github.com/apache/superset/pull/40973#issuecomment-4681322590
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(deps): cap paramiko <4.0 to keep SSH tunneling working [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40973:
URL: https://github.com/apache/superset/pull/40973#issuecomment-4683759734
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org