You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/13 08:34:28 UTC
[GitHub] [iceberg] openinx commented on a change in pull request #1558: load hive-site.xml for flink catalog
openinx commented on a change in pull request #1558:
URL: https://github.com/apache/iceberg/pull/1558#discussion_r503766389
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java
##########
@@ -52,13 +57,19 @@
// Can not just use "type", it conflicts with CATALOG_TYPE.
public static final String ICEBERG_CATALOG_TYPE = "catalog-type";
+
public static final String HIVE_URI = "uri";
public static final String HIVE_CLIENT_POOL_SIZE = "clients";
public static final String HADOOP_WAREHOUSE_LOCATION = "warehouse";
+ public static final String HIVE_SITE_PATH = "hive-site-path";
+ public static final String HIVE_SITE_SCHEME_FILE = "file";
Review comment:
If we plan to support hadoop path , would we still need the `file` or `hdfs` schema ? Just load those configurations files by hadoop filesystem ?
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java
##########
@@ -52,13 +57,19 @@
// Can not just use "type", it conflicts with CATALOG_TYPE.
public static final String ICEBERG_CATALOG_TYPE = "catalog-type";
+
public static final String HIVE_URI = "uri";
public static final String HIVE_CLIENT_POOL_SIZE = "clients";
public static final String HADOOP_WAREHOUSE_LOCATION = "warehouse";
+ public static final String HIVE_SITE_PATH = "hive-site-path";
Review comment:
Could we align with the `HiveCatalog` in flink by using `hive-conf-dir` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org