You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/13 15:37:43 UTC

[GitHub] [arrow] rtpsw commented on a diff in pull request #13375: ARROW-16823: [C++] Arrow Substrait enhancements for UDF

rtpsw commented on code in PR #13375:
URL: https://github.com/apache/arrow/pull/13375#discussion_r895867777


##########
cpp/src/arrow/engine/substrait/plan_internal.cc:
##########
@@ -92,6 +92,9 @@ Status AddExtensionSetToPlan(const ExtensionSet& ext_set, substrait::Plan* plan)
 
 Result<ExtensionSet> GetExtensionSetFromPlan(const substrait::Plan& plan,
                                              const ExtensionIdRegistry* registry) {

Review Comment:
   I'll need to check it out, but I think the code-safety issue discussed in [ARROW-16811](https://issues.apache.org/jira/browse/ARROW-16811) could apply here, i.e., a developer calling this function may let the argument default instead of exposing it to the user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org