You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2016/02/23 09:34:18 UTC

[jira] [Commented] (OAK-3893) SegmentWriter records cache could use thinner keys

    [ https://issues.apache.org/jira/browse/OAK-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158544#comment-15158544 ] 

Michael Dürig commented on OAK-3893:
------------------------------------

I think we should refactor that cache, make it a proper and generic record cache and move it to the top level.

> SegmentWriter records cache could use thinner keys
> --------------------------------------------------
>
>                 Key: OAK-3893
>                 URL: https://issues.apache.org/jira/browse/OAK-3893
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>            Priority: Minor
>
> The SegmentWriter keeps a records deduplication cache ('records' map) that maintains 2 types of mappings:
> * template -> recordid
> * strings -> recordid
> For the first one (template-> recordid) we can come up with a thinner representation of a template (a hash function that is fast and not very collision prone) so we don't have to keep a reference to each template object.
> Same applies for second one, similar to what is happening in the StringsCache now, we could keep the string value up to a certain size and beyond that, hash it and use that for the deduplication map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)